Skip to content

Commit 21b18ba

Browse files
committed
Update MacPackager.java
1 parent dfbb605 commit 21b18ba

File tree

1 file changed

+22
-24
lines changed

1 file changed

+22
-24
lines changed

src/main/java/io/github/fvarrui/javapackager/packagers/MacPackager.java

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,10 @@ public void doInit() throws Exception {
3535

3636
this.macConfig.setDefaults(this);
3737

38-
// FIX useResourcesAsWorkingDir=false doesn't work fine on Mac OS (option
39-
// disabled)
38+
// FIX useResourcesAsWorkingDir=false doesn't work fine on Mac OS (option disabled)
4039
if (!this.isUseResourcesAsWorkingDir()) {
4140
this.useResourcesAsWorkingDir = true;
42-
Logger.warn(
43-
"'useResourcesAsWorkingDir' property disabled on Mac OS (useResourcesAsWorkingDir is always true)");
41+
Logger.warn("'useResourcesAsWorkingDir' property disabled on Mac OS (useResourcesAsWorkingDir is always true)");
4442
}
4543

4644
}
@@ -119,7 +117,7 @@ private void processStartupScript() throws Exception {
119117
} else {
120118

121119
File launcher = macConfig.getCustomLauncher();
122-
if(launcher != null && launcher.canRead() && launcher.isFile()){
120+
if (launcher != null && launcher.canRead() && launcher.isFile()){
123121
FileUtils.copyFileToFolder(launcher, macOSFolder);
124122
this.executable = new File(macOSFolder, launcher.getName());
125123
} else {
@@ -237,28 +235,28 @@ private void manualDeepSign(File appFolder, String developerCertificateName, Fil
237235
CommandUtils.execute("find", findCommandArgs.toArray(new Object[0]));
238236

239237
// make sure the executable is signed last
240-
List<Object> codeSignCommandArgs = new ArrayList<>();
241-
codeSignCommandArgs.add("-f");
242-
addHardenedCodesign(codeSignCommandArgs);
243-
codeSignCommandArgs.add("--entitlements");
244-
codeSignCommandArgs.add(entitlements);
245-
codeSignCommandArgs.add("-s");
246-
codeSignCommandArgs.add(developerCertificateName);
247-
codeSignCommandArgs.add(this.executable);
238+
List<Object> codeSignExe = new ArrayList<>();
239+
codeSignExe.add("-f");
240+
addHardenedCodesign(codeSignExe);
241+
codeSignExe.add("--entitlements");
242+
codeSignExe.add(entitlements);
243+
codeSignExe.add("-s");
244+
codeSignExe.add(developerCertificateName);
245+
codeSignExe.add(this.executable);
248246

249-
CommandUtils.execute("codesign", codeSignCommandArgs.toArray(new Object[0]));
247+
CommandUtils.execute("codesign", codeSignExe.toArray(new Object[0]));
250248

251249
// finally, sign the top level directory
252-
List<Object> codeSignArgs2 = new ArrayList<>();
253-
codeSignArgs2.add("-f");
254-
addHardenedCodesign(codeSignArgs2);
255-
codeSignArgs2.add("--entitlements");
256-
codeSignArgs2.add(entitlements);
257-
codeSignArgs2.add("-s");
258-
codeSignArgs2.add(developerCertificateName);
259-
codeSignArgs2.add(appFolder);
260-
261-
CommandUtils.execute("codesign", codeSignArgs2.toArray(new Object[0]));
250+
List<Object> codeSignTopLevelDir = new ArrayList<>();
251+
codeSignTopLevelDir.add("-f");
252+
addHardenedCodesign(codeSignTopLevelDir);
253+
codeSignTopLevelDir.add("--entitlements");
254+
codeSignTopLevelDir.add(entitlements);
255+
codeSignTopLevelDir.add("-s");
256+
codeSignTopLevelDir.add(developerCertificateName);
257+
codeSignTopLevelDir.add(appFolder);
258+
259+
CommandUtils.execute("codesign", codeSignTopLevelDir.toArray(new Object[0]));
262260

263261
}
264262

0 commit comments

Comments
 (0)