Save user after sending the email

[harshitsinghai77]

Error while sending the email results in data being saved in the database and no email is sent to the person. This creates bad entry in the database.

It would be better to first send the email and then save the entry in the database.

https://github.com/izdwuut/fastapi-registration-tutorial/blob/main/routers/auth.py

await user.save()    
Mailer.send_confirmation_message(confirmation["token"], form_data.email)

swaping the statement would be a good idea.

[izdwuut]

Yeah, might be worth it. I updated this snippet with the following piece of code:

try:
    Mailer.send_confirmation_message(confirmation["token"], form_data.email)
except ConnectionRefusedError:
    raise HTTPException(
        status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
        detail="Email couldn't be send. Please try again."
    )
await user.save()