Checkpoint

Author: Aaron

dslink-v2/src/main/java/com/acuity/iot/dsa/dslink/protocol/v1/DS1LinkConnection.java

@@ -93,7 +93,6 @@ public void updateSalt(String salt) {
 
     @Override
     protected void checkConfig() {
-        configOk();
     }
 
     protected DS1ConnectionInit initializeConnection() {

dslink-v2/src/main/java/org/iot/dsa/dslink/requester/AbstractListHandler.java

@@ -3,13 +3,9 @@
 /**
  * Convenience implementation of the handler passed to the invoke method in the requester.
  * <p>
- * <p>
- * <p>
  * onUpdate will be called until the initial state is fully loaded.  After which onInitialized will
  * be called.  After that, onUpdate and onRemove will be called for state changes.
  * <p>
- * <p>
- * <p>
  * Configs, or node metadata names start with $.  Attributes start with @.  Anything else represents
  * a child.  Child maps will only contain configs/node metadata.
  *
@@ -45,8 +41,6 @@ public OutboundStream getStream() {
     /**
      * Sets the fields so they can be accessed with the corresponding getters.
      * <p>
-     * <p>
-     * <p>
      * {@inheritDoc}
      */
     @Override

dslink-v2/src/main/java/org/iot/dsa/node/DSNode.java

@@ -597,7 +597,8 @@ public DSIValue getValue(String name) {
     }
 
     /**
-     * Override point.  By default routes the request to the action.
+     * Override point.  It is safe to use the calling thread for long lived operations.  By
+     * default, this routes the request to the action's invoke method.
      *
      * @param action  Info for the action being invoked.
      * @param target  Info for the target (parent) of the action.  Could be this node,

dslink-v2/src/main/java/org/iot/dsa/node/action/DSAction.java

@@ -260,7 +260,9 @@ public ResultType getResultType() {
     }
 
     /**
-     * Execute the action invocation for the given target.
+     * Execute the action invocation for the given target.  It is safe to use the calling thread
+     * for long lived operations.  If the return type is void, perform the full operation on the
+     * calling thread so that errors will be properly reported.
      * <p>
      * To report an error, simply throw a runtime exception from this method, or call
      * ActionInvocation.close(Exception) when processing asynchronously.

dslink-v2/src/main/java/org/iot/dsa/time/DSDuration.java

@@ -20,6 +20,7 @@ public class DSDuration extends DSValue {
     /////////////////////////////////////////////////////////////////
 
     public static DSDuration NULL = new DSDuration();
+    public static DSDuration DEFAULT = new DSDuration();
 
     /////////////////////////////////////////////////////////////////
     // Instance Fields
@@ -184,8 +185,7 @@ public int getYears() {
 
     @Override
     public int hashCode() {
-        int ret = millis + seconds + minutes + hours + days + months + years;
-        return negative ? -ret : ret;
+        return toString().hashCode();
     }
 
     /**

dslink-v2/src/main/java/org/iot/dsa/util/DSStatusNode.java

@@ -55,6 +55,13 @@ public String getStatusText() {
         return statusText.getElement().toString();
     }
 
+    /**
+     * True if the status is good.
+     */
+    public boolean isOperational() {
+        return getStatus().isGood();
+    }
+
     ///////////////////////////////////////////////////////////////////////////
     // Protected Methods
     ///////////////////////////////////////////////////////////////////////////