fix(cli): resolve vm2 security vulnerability (#5070)

Author: sean-perkins

packages/@ionic/cli-framework-prompts/src/index.ts

@@ -1,5 +1,5 @@
 import { TERMINAL_INFO } from '@ionic/utils-terminal';
-import * as Debug from 'debug';
+import { debug as Debug } from 'debug';
 
 const debug = Debug('ionic:cli-framework-prompts');
 

packages/@ionic/cli-framework/src/lib/__tests__/options.ts

@@ -1,4 +1,4 @@
-import * as minimist from 'minimist';
+import minimist from 'minimist';
 
 import { CommandMetadata } from '../../definitions';
 import { OptionFilters, filterCommandLineOptions, filterCommandLineOptionsByGroup, metadataOptionsToParseArgsOptions, separateArgv, stripOptions, unparseArgs } from '../options';

packages/@ionic/cli-framework/src/lib/colors.ts

@@ -1,5 +1,5 @@
 import { ColorFunction, Colors as BaseColors } from '@ionic/cli-framework-output';
-import * as chalk from 'chalk';
+import chalk from 'chalk';
 import * as lodash from 'lodash';
 
 import { MetadataGroup } from '../definitions';

packages/@ionic/cli-framework/src/lib/help.ts

@@ -1,6 +1,6 @@
 import { filter, map } from '@ionic/utils-array';
 import { generateFillSpaceStringList, stringWidth, wordWrap } from '@ionic/utils-terminal';
-import * as Debug from 'debug';
+import { debug as Debug } from 'debug';
 import * as lodash from 'lodash';
 
 import { CommandMetadata, CommandMetadataInput, CommandMetadataOption, Footnote, HydratedCommandMetadata, HydratedNamespaceMetadata, ICommand, INamespace, LinkFootnote, MetadataGroup, NamespaceLocateResult, NamespaceMetadata } from '../definitions';
@@ -223,7 +223,7 @@ export class NamespaceStringHelpFormatter<C extends ICommand<C, N, M, I, O>, N e
 
     const filteredCommands = await filter(commands, async cmd => this.filterCommandCallback(cmd));
 
-    const [ cmdDetails, nsDetails ] = await Promise.all([
+    const [cmdDetails, nsDetails] = await Promise.all([
       this.getListOfCommandDetails(filteredCommands.filter(cmd => cmd.namespace === this.namespace)),
       this.getListOfNamespaceDetails(filteredCommands.filter(cmd => cmd.namespace !== this.namespace)),
     ]);

packages/@ionic/cli-framework/src/lib/options.ts

@@ -1,5 +1,5 @@
 import * as lodash from 'lodash';
-import * as minimist from 'minimist';
+import minimist from 'minimist';
 
 import { CommandLineOptions, CommandMetadataOption, HydratedParseArgsOptions, ParsedArg } from '../definitions';
 
@@ -19,7 +19,7 @@ export { ParsedArgs } from 'minimist';
  */
 export function stripOptions(pargv: readonly string[], { includeSeparated = true }: { includeSeparated?: boolean; }): string[] {
   const r = /^\-/;
-  const [ ownArgs, otherArgs ] = separateArgv(pargv);
+  const [ownArgs, otherArgs] = separateArgv(pargv);
   const filteredArgs = ownArgs.filter(arg => !r.test(arg));
 
   if (!includeSeparated) {
@@ -50,7 +50,7 @@ export function separateArgv(pargv: readonly string[]): [string[], string[]] {
     otherArgs.shift(); // strip separator
   }
 
-  return [ ownArgs, otherArgs ];
+  return [ownArgs, otherArgs];
 }
 
 /**
@@ -166,8 +166,8 @@ export function filterCommandLineOptions<O extends CommandMetadataOption>(option
 
   const pairs = Object.keys(parsedArgs)
     .map((k): [string, O | undefined, ParsedArg | undefined] => [k, mapped.get(k), parsedArgs[k]])
-    .filter(([ k, opt, value ]) => opt && predicate(opt, value))
-    .map(([ k, opt, value ]) => [opt ? opt.name : k, value]);
+    .filter(([k, opt, value]) => opt && predicate(opt, value))
+    .map(([k, opt, value]) => [opt ? opt.name : k, value]);
 
   return { ...initial, ...lodash.fromPairs(pairs) };
 }
@@ -221,7 +221,7 @@ export function unparseArgs(parsedArgs: minimist.ParsedArgs, { useDoubleQuotes,
   const dashKey = (k: string) => (k.length === 1 ? '-' : '--') + k;
 
   const pushPairs = (...pairs: [string, string | undefined][]) => {
-    for (const [ k, val ] of pairs) {
+    for (const [k, val] of pairs) {
       const key = dashKey(allowCamelCase ? k : k.replace(/[A-Z]/g, '-$&').toLowerCase());
 
       if (useEquals) {
@@ -274,7 +274,7 @@ export function unparseArgs(parsedArgs: minimist.ParsedArgs, { useDoubleQuotes,
     isKnown(k)
   );
 
-  for (const [ key, val ] of pairedOptions) {
+  for (const [key, val] of pairedOptions) {
     if (val === true) {
       pushPairs([key, undefined]);
     } else if (val === false && !ignoreFalse) {

packages/@ionic/cli-framework/src/lib/validators.ts

@@ -1,4 +1,4 @@
-import * as chalk from 'chalk';
+import chalk from 'chalk';
 
 import { ValidationError, Validator, Validators } from '../definitions';
 import { InputValidationError } from '../errors';

packages/@ionic/cli-framework/src/utils/ipc.ts

@@ -1,6 +1,6 @@
 import { fork } from '@ionic/utils-subprocess';
 import { ChildProcess } from 'child_process';
-import * as Debug from 'debug';
+import { debug as Debug } from 'debug';
 import * as fs from 'fs';
 
 import { ERROR_IPC_UNKNOWN_PROCEDURE, IPCError } from '../errors';

packages/@ionic/cli/.gitignore

@@ -3,3 +3,4 @@
 !jest.config.js
 !lint-staged.config.js
 *.d.ts
+*.tgz

packages/@ionic/cli/package.json

@@ -63,7 +63,7 @@
     "ssh-config": "^1.1.1",
     "stream-combiner2": "^1.1.1",
     "superagent": "^8.0.9",
-    "superagent-proxy": "^3.0.0",
+    "proxy-agent": "^6.3.0",
     "tar": "^6.0.1",
     "tslib": "^2.0.1"
   },
@@ -77,7 +77,6 @@
     "@types/semver": "^7.1.0",
     "@types/split2": "^2.1.6",
     "@types/superagent": "4.1.3",
-    "@types/superagent-proxy": "^3.0.0",
     "@types/tar": "^6.1.2",
     "jest": "^26.4.2",
     "jest-cli": "^26.0.1",

packages/@ionic/cli/src/bootstrap.ts

@@ -1,5 +1,5 @@
 import { compileNodeModulesPaths, readPackageJsonFile } from '@ionic/cli-framework/utils/node';
-import * as Debug from 'debug';
+import { debug as Debug } from 'debug';
 import * as path from 'path';
 import * as semver from 'semver';