fix(messaging, android): properly remove remote message from prefs

previously the remove was not applied, so it likely never persisted to
storage, leading to infinite growth and possible OOM

Author: mikehardy

packages/app/android/src/main/java/io/invertase/firebase/common/UniversalFirebasePreferences.java

@@ -74,6 +74,8 @@ public void clearAll() {
     getPreferences().edit().clear().apply();
   }
 
+  // Note the caller is responsible for calling apply() or commit() on the
+  // returned SharedPreferences.Editor object for the remove to take affect
   public SharedPreferences.Editor remove(String key) {
     return getPreferences().edit().remove(key);
   }

packages/messaging/android/src/main/java/io/invertase/firebase/messaging/ReactNativeFirebaseMessagingStoreImpl.java

@@ -74,7 +74,7 @@ public WritableMap getFirebaseMessageMap(String remoteMessageId) {
   @Override
   public void clearFirebaseMessage(String remoteMessageId) {
     UniversalFirebasePreferences preferences = UniversalFirebasePreferences.getSharedInstance();
-    preferences.remove(remoteMessageId);
+    preferences.remove(remoteMessageId).apply();
     // check and remove old notifications message
     String notificationIds = preferences.getStringValue(S_KEY_ALL_NOTIFICATION_IDS, "");
     if (!notificationIds.isEmpty()) {