fix(GH-224): HHH000104: firstResult/maxResults specified with collection fetch; applying in memory (#229)

* feat: Added initial support for streaming result list from query stream

* refactor: Wrapped result stream with Java proxy instance

* feat: Added initial query results stream support

* fix: Added  text/event-stream HTTP content negotiation for /graphql endpoint

* feat: Added support for SSE id,event,data spec

* chore: cleanup

* feat(test): Added test `@defer` streaming

* fix: Added SseEventBuilder wrapper

* refactor(web): Use Spring `@Transactional` annotation with read only

* fix(autoconfigure): Added support for merging additional types

* fix: firstResult/maxResults specified with collection fetch; applying in memory!

* fix: Added support for idClass attributes in keys query

* fix: Corrected keys query predicates for id class attributes

* refactor: Added hasIdAttribute and hasIdClassAttribute conditional check

* chore: polish

* refactor: Replaced constructors with builders for data fetchers

* fix: Revert paginationArgument to static final field

* refactor: Let's use Logical enum names for GraphQL input types

Author: igdianov

.gitignore

@@ -21,6 +21,9 @@ target/
 .project
 .springBeans
 .classpath
-
 .externalToolBuilders
+.sts4-cache
 
+# Scala
+.cache-main
+.cache-tests

graphql-jpa-query-autoconfigure/src/main/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLSchemaFactoryBean.java

@@ -4,10 +4,16 @@
 import static graphql.schema.FieldCoordinates.coordinates;
 import static graphql.util.TraversalControl.CONTINUE;
 
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Function;
+import java.util.function.Predicate;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
@@ -17,6 +23,7 @@
 import graphql.schema.DataFetcher;
 import graphql.schema.FieldCoordinates;
 import graphql.schema.GraphQLCodeRegistry;
+import graphql.schema.GraphQLDirective;
 import graphql.schema.GraphQLFieldDefinition;
 import graphql.schema.GraphQLFieldsContainer;
 import graphql.schema.GraphQLInterfaceType;
@@ -116,6 +123,26 @@ protected GraphQLSchema createInstance() throws Exception {
             .flatMap(Collection::stream)
             .collect(Collectors.toList());
 
+        Set<GraphQLDirective> directives = Stream.of(managedGraphQLSchemas)
+            .map(GraphQLSchema::getDirectives)
+            .flatMap(Collection::stream)
+            .filter(distinctByKeys(GraphQLDirective::getName))
+            .collect(Collectors.toSet());
+
+        if(!directives.isEmpty()) {
+            schemaBuilder.additionalDirectives(directives);
+        }
+        
+        Set<GraphQLType> types = Stream.of(managedGraphQLSchemas)
+                                       .map(GraphQLSchema::getAdditionalTypes)
+                                       .flatMap(Collection::stream)
+                                       .filter(distinctByKeys(GraphQLType::getName))
+                                       .distinct()
+                                       .collect(Collectors.toSet());
+        if (!types.isEmpty()) {
+            schemaBuilder.additionalTypes(types);
+        }
+        
         if(!mutations.isEmpty())
             schemaBuilder.mutation(GraphQLObjectType.newObject()
                                                     .name(this.mutationName)
@@ -137,6 +164,19 @@ protected GraphQLSchema createInstance() throws Exception {
         return schemaBuilder.codeRegistry(codeRegistryBuilder.build())
                             .build();
     }
+    
+    @SafeVarargs
+    private static <T> Predicate<T> distinctByKeys(Function<? super T, ?>... keyExtractors) {
+        final Map<List<?>, Boolean> seen = new ConcurrentHashMap<>();
+
+        return t -> {
+            final List<?> keys = Arrays.stream(keyExtractors)
+                                       .map(ke -> ke.apply(t))
+                                       .collect(Collectors.toList());
+
+            return seen.putIfAbsent(keys, Boolean.TRUE) == null;
+        };
+    }
 
     @Override
     public Class<?> getObjectType() {

graphql-jpa-query-autoconfigure/src/test/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLSchemaAutoConfigurationTest.java

@@ -27,6 +27,7 @@
 import com.introproventures.graphql.jpa.query.autoconfigure.support.QueryRoot;
 import com.introproventures.graphql.jpa.query.autoconfigure.support.SubscriptionRoot;
 
+import graphql.Directives;
 import graphql.GraphQL;
 import graphql.Scalars;
 import graphql.annotations.AnnotationsSchemaCreator;
@@ -36,6 +37,7 @@
 import graphql.annotations.annotationTypes.directives.definition.GraphQLDirectiveDefinition;
 import graphql.schema.FieldCoordinates;
 import graphql.schema.GraphQLCodeRegistry;
+import graphql.schema.GraphQLDirective;
 import graphql.schema.GraphQLFieldDefinition;
 import graphql.schema.GraphQLObjectType;
 import graphql.schema.GraphQLSchema;
@@ -201,6 +203,7 @@ public void configure(GraphQLShemaRegistration registry) {
                 GraphQLSchema graphQLSchema = GraphQLSchema.newSchema()
                                                            .query(query)
                                                            .codeRegistry(codeRegistry)
+                                                           .additionalDirective(Directives.DeferDirective)
                                                            .build();
 
                 registry.register(graphQLSchema);
@@ -216,6 +219,14 @@ public void contextLoads() {
 
     }
 
+    @Test
+    public void directivesSupport() {
+        assertThat(graphQLSchema.getDirectives())
+                .extracting(GraphQLDirective::getName)
+                .containsExactly("include", "skip", "defer");
+            
+    }
+    
     @Test
     public void querySchemaConfigurer() {
         // given

graphql-jpa-query-schema/pom.xml

@@ -27,6 +27,11 @@
             <groupId>org.atteo</groupId>
             <artifactId>evo-inflector</artifactId>
         </dependency>
+        
+        <dependency>
+            <groupId>io.projectreactor</groupId>
+            <artifactId>reactor-core</artifactId>
+        </dependency>
 
         <dependency>
             <groupId>org.slf4j</groupId>

graphql-jpa-query-schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/EntityIntrospector.java

@@ -27,6 +27,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.introproventures.graphql.jpa.query.annotation.GraphQLDefaultOrderBy;
 import com.introproventures.graphql.jpa.query.annotation.GraphQLDescription;
 import com.introproventures.graphql.jpa.query.annotation.GraphQLIgnore;
 import com.introproventures.graphql.jpa.query.introspection.ClassDescriptor;
@@ -284,6 +285,14 @@ public Optional<String> getSchemaDescription() {
             public boolean hasSchemaDescription() {
                 return getSchemaDescription().isPresent();
             }
+
+            public boolean hasDefaultOrderBy() {
+                return getDefaultOrderBy().isPresent();
+            }
+            
+            public Optional<GraphQLDefaultOrderBy> getDefaultOrderBy() {
+                return getAnnotation(GraphQLDefaultOrderBy.class);
+            }
 
             public boolean isTransient() {
                 return !attribute.isPresent();