refactor(*): clippy single char pattern and needless borrow lints

Signed-off-by: Ömer Talha Özdemir <omertoast@gmail.com>

Author: omertoast

crates/ilp-node/src/main.rs

@@ -376,7 +376,7 @@ fn set_app_env(env_config: &Config, app: &mut App<'_, '_>, path: &[String], dept
     if depth == 1 {
         for item in &mut app.p.opts {
             if let Ok(value) = env_config.get_str(&item.b.name.to_lowercase()) {
-                item.v.env = Some((&OsStr::new(item.b.name), Some(OsString::from(value))));
+                item.v.env = Some((OsStr::new(item.b.name), Some(OsString::from(value))));
             }
         }
         return;

crates/ilp-node/src/node.rs

@@ -375,7 +375,7 @@ impl InterledgerNode {
                 }
                 Err(RejectBuilder {
                     code: ErrorCode::F02_UNREACHABLE,
-                    message: &format!(
+                    message: format!(
                         // TODO we might not want to expose the internal account ID in the error
                         "No outgoing route for account: {} (ILP address of the Prepare packet: {})",
                         request.to.id(),

crates/interledger-api/src/routes/accounts.rs

@@ -415,7 +415,7 @@ where
             let server_secret_clone = server_secret.clone();
             async move {
                 if let Some(ref username) = default_spsp_account {
-                    let id = store.get_account_id_from_username(&username).await?;
+                    let id = store.get_account_id_from_username(username).await?;
 
                     // TODO this shouldn't take multiple store calls
                     let mut accounts = store.get_accounts(vec![id]).await?;

crates/interledger-api/src/routes/node_settings.rs

@@ -133,7 +133,7 @@ where
                 // Convert the usernames to account IDs to set the routes in the store
                 let mut usernames: Vec<Username> = Vec::new();
                 for username in routes.values() {
-                    let user = match Username::from_str(&username) {
+                    let user = match Username::from_str(username) {
                         Ok(u) => u,
                         Err(_) => return Err(Rejection::from(ApiError::bad_request())),
                     };

crates/interledger-btp/src/packet.rs

@@ -568,7 +568,7 @@ mod tests {
         #[test]
         fn from_bytes() {
             assert_eq!(
-                BtpMessage::from_bytes(&MESSAGE_1_SERIALIZED).unwrap(),
+                BtpMessage::from_bytes(MESSAGE_1_SERIALIZED).unwrap(),
                 *MESSAGE_1
             );
         }
@@ -597,7 +597,7 @@ mod tests {
         #[test]
         fn from_bytes() {
             assert_eq!(
-                BtpResponse::from_bytes(&RESPONSE_1_SERIALIZED).unwrap(),
+                BtpResponse::from_bytes(RESPONSE_1_SERIALIZED).unwrap(),
                 *RESPONSE_1
             );
         }
@@ -625,7 +625,7 @@ mod tests {
 
         #[test]
         fn from_bytes() {
-            assert_eq!(BtpError::from_bytes(&ERROR_1_SERIALIZED).unwrap(), *ERROR_1);
+            assert_eq!(BtpError::from_bytes(ERROR_1_SERIALIZED).unwrap(), *ERROR_1);
         }
 
         #[test]

crates/interledger-btp/src/server.rs

@@ -113,7 +113,7 @@ where
     let (auth, mut connection) = get_auth(Box::pin(connection)).await?;
     debug!("Got BTP connection for username: {}", username);
     let account = store
-        .get_account_from_btp_auth(&username, &auth.token.expose_secret())
+        .get_account_from_btp_auth(&username, auth.token.expose_secret())
         .map_err(move |_| warn!("BTP connection does not correspond to an account"))
         .await?;
 

crates/interledger-ccp/src/server.rs

@@ -439,7 +439,7 @@ where
                 warn!("Error handling incoming Route Update request, sending a Route Control request to get updated routing table info from peer. Error was: {}", &message);
                 let reject = RejectBuilder {
                     code: ErrorCode::F00_BAD_REQUEST,
-                    message: &message.as_bytes(),
+                    message: message.as_bytes(),
                     data: &[],
                     triggered_by: Some(&self.ilp_address.read()),
                 }

crates/interledger-http/src/server.rs

@@ -43,7 +43,7 @@ where
     }
     Ok(store
         .get_account_from_http_auth(
-            &path_username,
+            path_username,
             &password.expose_secret()[BEARER_TOKEN_START..],
         )
         .await?)

crates/interledger-ildcp/src/server.rs

@@ -37,7 +37,7 @@ where
         if is_ildcp_request(&request.prepare) {
             let from = request.from.ilp_address();
             let builder = IldcpResponseBuilder {
-                ilp_address: &from,
+                ilp_address: from,
                 asset_code: request.from.asset_code(),
                 asset_scale: request.from.asset_scale(),
             };

crates/interledger-packet/src/address.rs

@@ -161,7 +161,7 @@ impl Address {
         unsafe {
             self.0
                 .split(|&b| b == b'.')
-                .map(|s| str::from_utf8_unchecked(&s))
+                .map(|s| str::from_utf8_unchecked(s))
         }
     }