CE 1.9: native fallback system broken

[mmenozzi]

Hi,
as stated here http://www.magentocommerce.com/knowledge-base/entry/ee114-ce19-rwd-dev-guide#changes-fallback, Magento CE 1.9 introduces parent/child theme configuration as explained by Alan Storm's article http://alanstorm.com/magento_parent_child_themes.

I think that the rewrite of Mage_Core_Model_Design_Package added in the RedLightBlinking_Setup module doesn't support this behavior.

I tried to install b-responsive on Magento CE 1.9 and have my default theme in my custom package to be a child of b-responsive itself and it didn't work. If I disable the RedLightBlinking_Setup module (so the rewrite) my theme works as expected and inherits from b-responsive.

How can we solve that? Should we add a version check in the rewrited model?

[simkea]

I know this is not the best solution.
Uncomment the following lines

.modman\b-responsive\app\code\community\RedLightBlinking\Setup\etc\config.xml
Lines 19-25:

    <!--<models>-->
        <!--<core>-->
            <!--<rewrite>-->
                <!--<design_package>RedLightBlinking_Setup_Model_Core_Design_Package</design_package>-->
            <!--</rewrite>-->
        <!--</core>-->
    <!--</models>-->

I can not say whether this Community or Enterprise works correctly.
But it works for me and I can make an inheritance of b-responsive.

[rubytastic]

How does this relate to a non modman installed theme?

Im now using this for a new project, would love to give back to this project any fixes corrections I can make. If authors of Repo can add me as repository contributor we could combine efforts fixing any outstanding issues and resolve them straight away. And please cleanup the repo issue list or let me close old topics that no longer relevant.

[mmenozzi]

@rubytastic you should contribute using pull requests: https://help.github.com/articles/using-pull-requests/

[mmenozzi]

@magentogirl @enriquepiatti @princesslola there are some news about this issue. You're declaring b-responsive as compatible with 1.9 but this issue remains...

[mmenozzi]

@magentogirl @enriquepiatti @princesslola I analyzed the problem a little bit more in detail. The logic implemented by Mage_Core_Model_Design_Package is to have that b-responsive/default with the following fallback scheme:

• _theme: current | _package: current
• _theme: default | _package: current
• _theme: default | _package: enterprise
• _theme: default | _package: default
• _theme: default | _package: base (this is mandatory)

Without that rewrite the fallback would be:

• _theme: current | _package: current
• _theme: default | _package: current
• _theme: default | _package: base (this is mandatory)

So I think that that rewrite is done to have that b-responsive/default inherits from default/default instead from base/default. But this rewrite breaks the configurable fallback as stated above. I am right?

If so I think that with Magento CE >= 1.9.x this should be done with configurable fallback (theme.xml).
So I propose the following changes.

• Modify the Mage_Core_Model_Design_Package::getFilename() method by prepending:

if (version_compare(Mage::getVersion(), '1.9.0.0', '>=')) {
        return parent::getFilename($file, $params);
}

• Modify the Mage_Core_Model_Design_Package::getSkinUrl() method by prepending:

if (version_compare(Mage::getVersion(), '1.9.0.0', '>=')) {
        return parent::getFilename($file, $params);
}

• Add the the file app/design/frontend/b-responsive/default/etc/theme.xml with the following content:

<?xml version="1.0"?>
<theme>
    <parent>default/default</parent>
</theme>

• Add the the file app/design/frontend/b-responsive/enterprise/etc/theme.xml with the following content:

<?xml version="1.0"?>
<theme>
    <parent>enterprise/default</parent>
</theme>

What you say?
Can I proceed with a pull request?