Skip to content

fix: Fix more type hints to use the covariant Sequence instead of the invariant List #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silasary wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

fix: Fix more type hints to use the covariant Sequence instead of the invariant List #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions interactions/api/http/http_requests/interactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, cast
from typing import TYPE_CHECKING, Sequence, cast

import discord_typings

Expand Down Expand Up @@ -84,7 +84,7 @@ async def get_application_commands(
)

async def overwrite_application_commands(
self, app_id: "Snowflake_Type", data: list[dict], guild_id: "Snowflake_Type"
self, app_id: "Snowflake_Type", data: Sequence[dict], guild_id: "Snowflake_Type"
) -> list[discord_typings.ApplicationCommandData]: # todo type "data"
"""
Take a list of commands and overwrite the existing command list within the given scope
Expand Down
16 changes: 8 additions & 8 deletions interactions/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,8 +1165,8 @@ async def wait_for_component(
self,
messages: Union[Message, int, list],
components: Union[
List[List[Union["BaseComponent", dict]]],
List[Union["BaseComponent", dict]],
Sequence[Sequence[Union["BaseComponent", dict]]],
Sequence[Union["BaseComponent", dict]],
"BaseComponent",
dict,
],
Expand All @@ -1179,8 +1179,8 @@ async def wait_for_component(
self,
*,
components: Union[
List[List[Union["BaseComponent", dict]]],
List[Union["BaseComponent", dict]],
Sequence[Sequence[Union["BaseComponent", dict]]],
Sequence[Union["BaseComponent", dict]],
"BaseComponent",
dict,
],
Expand All @@ -1193,8 +1193,8 @@ async def wait_for_component(
self,
messages: None,
components: Union[
List[List[Union["BaseComponent", dict]]],
List[Union["BaseComponent", dict]],
Sequence[Sequence[Union["BaseComponent", dict]]],
Sequence[Union["BaseComponent", dict]],
"BaseComponent",
dict,
],
Expand Down Expand Up @@ -1661,7 +1661,7 @@ async def sync_scope(
self,
cmd_scope: "Snowflake_Type",
delete_cmds: bool,
local_cmds_json: Dict["Snowflake_Type", List[Dict[str, Any]]],
local_cmds_json: Dict["Snowflake_Type", Sequence[Dict[str, Any]]],
) -> None:
"""
Sync a single scope.
Expand Down Expand Up @@ -1746,7 +1746,7 @@ def _build_sync_payload(
return sync_payload, sync_needed_flag

async def _sync_commands_with_discord(
self, sync_payload: List[Dict[str, Any]], cmd_scope: "Snowflake_Type"
self, sync_payload: Sequence[Dict[str, Any]], cmd_scope: "Snowflake_Type"
) -> None:
"""
Sync the commands with discord.
Expand Down