fix!: Fix changing role positions (#743)

* fix!: Fix changing role positions

Changed the api request function to send an JSON array instead of a single object, and made the relevant changes in Guild and Role's corresponding helper functions. Also added a Guild.modify_role_positions() function to handle multiple position changes at once.

* refactor: fixed payload type hint

Author: dacid44

interactions/api/http/guild.py

@@ -404,21 +404,20 @@ async def create_guild_role(
 
         return request
 
-    async def modify_guild_role_position(
-        self, guild_id: int, role_id: int, position: int, reason: Optional[str] = None
+    async def modify_guild_role_positions(
+        self, guild_id: int, payload: List[dict], reason: Optional[str] = None
     ) -> List[dict]:
         """
         Modify the position of a role in the guild.
 
         :param guild_id: Guild ID snowflake.
-        :param role_id: Role ID snowflake.
-        :param position: The new position of the associated role.
+        :param payload: A list of dicts containing the role IDs and new positions for all the roles to be moved.
         :param reason: The reason for this action, if given.
         :return: List of guild roles with updated hierarchy.
         """
         return await self._req.request(
             Route("PATCH", f"/guilds/{guild_id}/roles"),
-            json={"id": role_id, "position": position},
+            json=payload,
             reason=reason,
         )
 

interactions/api/http/guild.pyi

@@ -64,8 +64,8 @@ class _GuildRequest:
     async def create_guild_role(
         self, guild_id: int, payload: dict, reason: Optional[str] = None
     ) -> dict: ...
-    async def modify_guild_role_position(
-        self, guild_id: int, role_id: int, position: int, reason: Optional[str] = None
+    async def modify_guild_role_positions(
+        self, guild_id: int, payload: List[dict], reason: Optional[str] = None
     ) -> List[dict]: ...
     async def modify_guild_role(
         self, guild_id: int, role_id: int, payload: dict, reason: Optional[str] = None

interactions/api/models/guild.py

@@ -1606,11 +1606,36 @@ async def modify_role_position(
         :return: List of guild roles with updated hierarchy
         :rtype: List[Role]
         """
+        return await self.modify_role_positions(
+            changes=[{"id": role_id, "position": position}], reason=reason
+        )
+
+    async def modify_role_positions(
+        self,
+        changes: List[dict],
+        reason: Optional[str] = None,
+    ) -> List[Role]:
+        """
+        Modifies the positions of multiple roles in the guild.
+
+        :param changes: A list of dicts containing roles (id) and their new positions (position)
+        :type changes: List[dict]
+        :param reason?: The reason for the modifying
+        :type reason: Optional[str]
+        :return: List of guild roles with updated hierarchy
+        :rtype: List[Role]
+        """
         if not self._client:
             raise AttributeError("HTTPClient not found!")
-        _role_id = role_id.id if isinstance(role_id, Role) else role_id
-        res = await self._client.modify_guild_role_position(
-            guild_id=int(self.id), position=position, role_id=_role_id, reason=reason
+        res = await self._client.modify_guild_role_positions(
+            guild_id=int(self.id),
+            payload=[
+                {"id": int(change["id"].id), "position": change["position"]}
+                if isinstance(change["id"], Role)
+                else change
+                for change in changes
+            ],
+            reason=reason,
         )
         return [Role(**role, _client=self._client) for role in res]
 

interactions/api/models/guild.pyi

@@ -416,6 +416,11 @@ class Guild(DictSerializerMixin):
         position: int,
         reason: Optional[str] = None,
     ) -> List[Role]: ...
+    async def modify_role_positions(
+        self,
+        changes: List[dict],
+        reason: Optional[str] = None,
+    ) -> List[Role]: ...
     async def get_bans(
         self,
         limit: Optional[int] = 1000,

interactions/api/models/role.py

@@ -164,7 +164,9 @@ async def modify_position(
         """
         if not self._client:
             raise AttributeError("HTTPClient not found!")
-        res = await self._client.modify_guild_role_position(
-            guild_id=guild_id, position=position, role_id=int(self.id), reason=reason
+        res = await self._client.modify_guild_role_positions(
+            guild_id=guild_id,
+            payload=[{"position": position, "id": int(self.id)}],
+            reason=reason,
         )
         return [Role(**role, _client=self._client) for role in res]