Xu auto clang format 11 check (#1261) (#1262)

* add auto clang-format before build.
* check with clang-format-11

Author: xuhancn

cmake/ClangFormat.cmake

@@ -0,0 +1,20 @@
+## Include to trigger clang-format
+if(BUILD_NO_CLANGFORMAT)
+  return()
+endif()
+
+if(CLANGFORMAT_enabled)
+  return()
+endif()
+set(CLANGFORMAT_enabled true)
+
+set(CFMT_STYLE ${IPEX_PROJECT_TOP_DIR}/.clang-format)
+if(NOT EXISTS ${CFMT_STYLE})
+  message(WARNING "Cannot find style file ${CFMT_STYLE}!")
+  return()
+endif()
+
+find_program(CLANG_FORMAT "clang-format")
+if(NOT CLANG_FORMAT)
+  message(WARNING "Please install clang-format before contributing to IPEX!")
+endif()

csrc/cpu/CMakeLists.txt

@@ -137,6 +137,14 @@ list(REMOVE_ITEM IPEX_CPU_CPP_SRCS ${IPEX_CPU_CPP_ISA_SRCS_ORIGIN})
 
 add_library(${PLUGIN_NAME_CPU} SHARED ${IPEX_CPU_CPP_SRCS})
 
+include(${IPEX_PROJECT_TOP_DIR}/cmake/ClangFormat.cmake)
+if(CLANG_FORMAT)
+  file(GLOB_RECURSE ALL_NATIVE_CSRC_FILES ${IPEX_CPU_CPP_ROOT}/**.[ch] ${IPEX_CPU_CPP_ROOT}/**.[ch]pp 
+      ${IPEX_JIT_CPP_ROOT}/**.[ch] ${IPEX_JIT_CPP_ROOT}/**.[ch]pp ${IPEX_UTLIS_CPP_ROOT}/**.[ch] ${IPEX_UTLIS_CPP_ROOT}/**.[ch]pp)
+  add_custom_target(CL_FORMAT_CPU_NATIVE_CSRC COMMAND clang-format -i -style=file ${ALL_NATIVE_CSRC_FILES})
+  add_dependencies(${PLUGIN_NAME_CPU} CL_FORMAT_CPU_NATIVE_CSRC)
+endif()
+
 link_directories(${PYTORCH_INSTALL_DIR}/lib)
 add_dependencies(${PLUGIN_NAME_CPU} dnnl_graph)
 # If Graph Compiler is built, then it should link to its LLVM dependencies,

csrc/cpu/aten/kernels/PackedMklSgemmKrnl.cpp

@@ -32,8 +32,8 @@ at::Tensor mkl_sgemm_packB_impl(
     const int64_t N,
     const int64_t K,
     const at::Tensor& ori_weight) {
-  int64_t pack_size =
-      (int64_t)(cblas_sgemm_pack_get_size(CblasBMatrix, M, N, K) / sizeof(float) + 1);
+  int64_t pack_size = (int64_t)(
+      cblas_sgemm_pack_get_size(CblasBMatrix, M, N, K) / sizeof(float) + 1);
   at::Tensor mkl_weight = at::empty(pack_size, at::kFloat);
   _mkl_sgemm_packB_impl(M, N, K, ori_weight, mkl_weight);
   return mkl_weight;

intel_extension_for_pytorch/csrc/python/CMakeLists.txt

@@ -72,5 +72,12 @@ set(IPEX_PYTHON_CPP_SRCS ${IPEX_PYTHON_CPP_CPU_SRCS})
 
 add_library(${PLUGIN_NAME_PYTHON} SHARED ${IPEX_PYTHON_CPP_SRCS})
 
+include(${IPEX_PROJECT_TOP_DIR}/cmake/ClangFormat.cmake)
+if(CLANG_FORMAT)
+  file(GLOB_RECURSE ALL_NATIVE_CSRC_FILES ${PROJECT_SOURCE_DIR}/**.[ch] ${PROJECT_SOURCE_DIR}/**.[ch]pp)
+  add_custom_target(CL_FORMAT_PYTHON_NATIVE_CSRC COMMAND clang-format -i -style=file ${ALL_NATIVE_CSRC_FILES})
+  add_dependencies(${PLUGIN_NAME_PYTHON} CL_FORMAT_PYTHON_NATIVE_CSRC)
+endif()
+
 target_link_directories(${PLUGIN_NAME_PYTHON} PUBLIC ${IPEX_INSTALL_LIBDIR})
 target_link_libraries(${PLUGIN_NAME_PYTHON} PUBLIC intel-ext-pt-cpu)

setup.py

@@ -353,7 +353,9 @@ def write_buffer_to_file(file_path, buffer):
         return
 
     c_buffer = '// Autogenerated file, do not edit!\n'
-    c_buffer += '// code fingerprint: {}\n\n'.format(current_code_fingerprint)
+    c_buffer += '// clang-format off\n'
+    c_buffer += '// code fingerprint: {}\n'.format(current_code_fingerprint)
+    c_buffer += '// clang-format on\n\n'
     c_buffer += '#pragma once\n'
     c_buffer += '#include <string>\n\n'
     c_buffer += 'namespace torch_ipex {\n\n'