fix(capacity-provider): incorrect iteration for resource list outputs

Author: saumitra-dev

modules/capacity-provider/main.tf

@@ -35,15 +35,16 @@ resource "aws_ecs_capacity_provider" "this" {
 resource "aws_ecs_cluster_capacity_providers" "this" {
   cluster_name = var.ecs_cluster_name
 
-  capacity_providers = [for i in var.capacity_providers : element(var.capacity_providers, i).name]
+  capacity_providers = [for capacity_provider in var.capacity_providers : capacity_provider.name]
 
   dynamic "default_capacity_provider_strategy" {
     for_each = var.default_capacity_provider_strategies
+    iterator = default_capacity_provider_strategies
 
     content {
-      capacity_provider = each.value.capacity_provider
-      base              = each.value.base
-      weight            = each.value.weight
+      capacity_provider = default_capacity_provider_strategies.value.capacity_provider
+      base              = default_capacity_provider_strategies.value.base
+      weight            = default_capacity_provider_strategies.value.weight
     }
   }
 }

modules/capacity-provider/outputs.tf

@@ -4,12 +4,12 @@
 
 output "ids" {
   description = "Identifiers for the ECS Capacity Providers"
-  value       = [for i in aws_ecs_capacity_provider.this : aws_ecs_capacity_provider.this[i].id]
+  value       = [for ecs_capacity_provider in aws_ecs_capacity_provider.this : ecs_capacity_provider.id]
 }
 
 output "arns" {
   description = "ARNs for the ECS Capacity Providers"
-  value       = [for i in aws_ecs_capacity_provider.this : aws_ecs_capacity_provider.this[i].arn]
+  value       = [for ecs_capacity_provider in aws_ecs_capacity_provider.this : ecs_capacity_provider.arn]
 }
 
 ################################################################################