fix(alb): incorrect key values in alb listeners outputs

Change variable type for listeners to `map` instead of `list` for better referencing.

Author: saumitra-dev

modules/alb/README.md

@@ -30,7 +30,7 @@ No modules.
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_internal"></a> [internal](#input\_internal) | Either the ALB is internal or internet-facing | `bool` | `false` | no |
-| <a name="input_listeners"></a> [listeners](#input\_listeners) | Listeners to forward ALB ingress to desired Target Groups | <pre>list(object({<br>    default_action = list(object({<br>      type                 = string<br>      target_group         = string<br>      authenticate_cognito = optional(any, {})<br>      authenticate_oidc    = optional(any, {})<br>      fixed_response       = optional(any, {})<br>      forward              = optional(any, {})<br>      order                = optional(number)<br>      redirect             = optional(any, {})<br>    }))<br>    alpn_policy           = optional(string)<br>    certificate_arn       = optional(string)<br>    mutual_authentication = optional(any, {})<br>    port                  = optional(number)<br>    protocol              = optional(string)<br>    ssl_policy            = optional(string)<br>    tags                  = optional(map(any), {})<br>  }))</pre> | n/a | yes |
+| <a name="input_listeners"></a> [listeners](#input\_listeners) | Listeners to forward ALB ingress to desired Target Groups | <pre>map(object({<br>    default_action = list(object({<br>      type                 = string<br>      target_group         = string<br>      authenticate_cognito = optional(any, {})<br>      authenticate_oidc    = optional(any, {})<br>      fixed_response       = optional(any, {})<br>      forward              = optional(any, {})<br>      order                = optional(number)<br>      redirect             = optional(any, {})<br>    }))<br>    alpn_policy           = optional(string)<br>    certificate_arn       = optional(string)<br>    mutual_authentication = optional(any, {})<br>    port                  = optional(number)<br>    protocol              = optional(string)<br>    ssl_policy            = optional(string)<br>    tags                  = optional(map(any), {})<br>  }))</pre> | n/a | yes |
 | <a name="input_name"></a> [name](#input\_name) | Name of the ALB | `string` | `""` | no |
 | <a name="input_preserve_host_header"></a> [preserve\_host\_header](#input\_preserve\_host\_header) | Whether the ALB should preserve the Host Header in HTTP requests and send it to the target without any changes | `bool` | `false` | no |
 | <a name="input_security_groups_ids"></a> [security\_groups\_ids](#input\_security\_groups\_ids) | Identifiers of Security Groups for the ALB | `list(string)` | `[]` | no |

modules/alb/main.tf

@@ -54,28 +54,28 @@ resource "aws_lb_target_group" "this" {
 ################################################################################
 
 resource "aws_lb_listener" "this" {
-  count = length(var.listeners)
+  for_each = var.listeners
 
   load_balancer_arn = aws_lb.this.arn
 
-  alpn_policy     = element(var.listeners, count.index).alpn_policy
-  certificate_arn = element(var.listeners, count.index).certificate_arn
-  port            = element(var.listeners, count.index).port
-  protocol        = element(var.listeners, count.index).protocol
-  ssl_policy      = element(var.listeners, count.index).ssl_policy
+  alpn_policy     = each.value.alpn_policy
+  certificate_arn = each.value.certificate_arn
+  port            = each.value.port
+  protocol        = each.value.protocol
+  ssl_policy      = each.value.ssl_policy
 
   dynamic "mutual_authentication" {
-    for_each = length(element(var.listeners, count.index).mutual_authentication != null ? element(var.listeners, count.index).mutual_authentication : {}) > 0 ? [1] : []
+    for_each = length(each.value.mutual_authentication != null ? each.value.mutual_authentication : {}) > 0 ? [1] : []
 
     content {
-      mode                             = element(var.listeners, count.index).mutual_authentication.mode
-      trust_store_arn                  = element(var.listeners, count.index).mutual_authentication.trust_store_arn
-      ignore_client_certificate_expiry = try(element(var.listeners, count.index).mutual_authentication.ignore_client_certificate_expiry, null)
+      mode                             = each.value.mutual_authentication.mode
+      trust_store_arn                  = each.value.mutual_authentication.trust_store_arn
+      ignore_client_certificate_expiry = try(each.value.mutual_authentication.ignore_client_certificate_expiry, null)
     }
   }
 
   dynamic "default_action" {
-    for_each = element(var.listeners, count.index).default_action
+    for_each = each.value.default_action
     iterator = default_action
 
     content {
@@ -166,5 +166,5 @@ resource "aws_lb_listener" "this" {
     }
   }
 
-  tags = element(var.listeners, count.index).tags
+  tags = each.value.tags
 }

modules/alb/variables.tf

@@ -61,7 +61,7 @@ variable "target_groups" {
 
 variable "listeners" {
   description = "Listeners to forward ALB ingress to desired Target Groups"
-  type = list(object({
+  type = map(object({
     default_action = list(object({
       type                 = string
       target_group         = string