fix broken migrations over the years

Author: drusepth

db/migrate/20140713043535_create_models.rb

@@ -98,7 +98,7 @@ def change
       t.text :description
 
       # Map
-      t.attachment :map
+      t.string :map
 
       # Culture
       t.string :population

db/migrate/20170216211914_add_src_to_image_uploads.rb

@@ -1,9 +1,5 @@
 class AddSrcToImageUploads < ActiveRecord::Migration[4.2]
   def self.up
-  	add_attachment :image_uploads, :src
-  end
-
-  def self.down
-  	remove_attachment :image_uploads, :src
+    add_column  :image_uploads, :src, :string
   end
 end

db/migrate/20180110200009_upgrade_thredded_v0_14_to_v0_15.rb

@@ -83,9 +83,31 @@ def change # rubocop:disable Metrics/MethodLength
 
   private
 
+  #def remove_string_limit(table, column, type: :text, indices: [])
+  #  indices.each { |(_, options)| remove_index table, name: options[:name] }
+  #  change_column table, column, type, **{ limit: nil }
+  #  indices.each { |args| add_index table, *args }
+  #end
+
   def remove_string_limit(table, column, type: :text, indices: [])
-    indices.each { |(_, options)| remove_index table, name: options[:name] }
+    indices.each do |index|
+      if index.is_a?(Hash) && index[:name] # Ensure index is a hash with :name key
+        puts "Removing index: #{index[:name]}"
+        remove_index table, name: index[:name]
+      else
+        puts "Skipping malformed index entry: #{index.inspect}"
+      end
+    end
+
     change_column table, column, type, limit: nil
-    indices.each { |args| add_index table, *args }
+
+    indices.each do |index|
+      if index.is_a?(Hash) && index[:columns] # Ensure index has required keys
+        puts "Re-adding index: #{index[:name]}"
+        add_index table, index[:columns], name: index[:name], unique: index[:unique], length: index[:length]
+      else
+        puts "Skipping malformed index entry: #{index.inspect}"
+      end
+    end
   end
 end

db/migrate/20180930063614_upgrade_thredded_v0_15_to_v0_16.rb

@@ -4,6 +4,8 @@
 
 class UpgradeThreddedV015ToV016 < Thredded::BaseMigration
   def up
+    add_column :thredded_topics, :deleted_at, :datetime
+
     %i[thredded_user_topic_read_states thredded_user_private_topic_read_states].each do |table_name|
       add_column table_name, :unread_posts_count, :integer, default: 0, null: false
       add_column table_name, :read_posts_count, :integer, default: 0, null: false
@@ -21,6 +23,8 @@ def up
   end
 
   def down
+    remove_column :thredded_topics, :deleted_at
+
     remove_column :thredded_user_topic_read_states, :messageboard_id
     %i[thredded_user_topic_read_states thredded_user_private_topic_read_states].each do |table|
       remove_column table, :unread_posts_count

db/migrate/20210308072329_add_deleted_at_date_times_to_thredded_tables.rb

@@ -1,6 +1,6 @@
 class AddDeletedAtDateTimesToThreddedTables < ActiveRecord::Migration[6.0]
   def change
-    add_column :thredded_topics, :deleted_at, :datetime
+    #add_column :thredded_topics, :deleted_at, :datetime
     add_index :thredded_topics, :deleted_at
     add_index :thredded_topics, [:deleted_at, :messageboard_id]
     add_index :thredded_topics, [:deleted_at, :user_id]

db/schema.rb

@@ -215,7 +215,7 @@
   create_table "basil_feedbacks", force: :cascade do |t|
     t.integer "basil_commission_id", null: false
     t.integer "user_id", null: false
-    t.integer "score_adjustment"
+    t.integer "score_adjustment", default: 0
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
     t.index ["basil_commission_id"], name: "index_basil_feedbacks_on_basil_commission_id"
@@ -1669,10 +1669,7 @@
     t.integer "content_id"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
-    t.string "src_file_name"
-    t.string "src_content_type"
-    t.bigint "src_file_size"
-    t.datetime "src_updated_at"
+    t.string "src"
     t.index ["content_type", "content_id"], name: "index_image_uploads_on_content_type_and_content_id"
     t.index ["user_id"], name: "index_image_uploads_on_user_id"
   end
@@ -1941,10 +1938,6 @@
     t.string "name", null: false
     t.string "type_of"
     t.text "description"
-    t.string "map_file_name"
-    t.string "map_content_type"
-    t.integer "map_file_size"
-    t.datetime "map_updated_at"
     t.string "population"
     t.string "language"
     t.string "currency"
@@ -3216,7 +3209,7 @@
     t.datetime "updated_at", null: false
     t.boolean "locked", default: false, null: false
     t.index ["messageboard_group_id"], name: "index_thredded_messageboards_on_messageboard_group_id"
-    t.index ["slug"], name: "index_thredded_messageboards_on_slug", unique: true
+    t.index ["slug"], name: "index_thredded_messageboards_on_slug"
   end
 
   create_table "thredded_notifications_for_followed_topics", force: :cascade do |t|
@@ -3291,7 +3284,7 @@
     t.datetime "updated_at", null: false
     t.index ["hash_id"], name: "index_thredded_private_topics_on_hash_id"
     t.index ["last_post_at"], name: "index_thredded_private_topics_on_last_post_at"
-    t.index ["slug"], name: "index_thredded_private_topics_on_slug", unique: true
+    t.index ["slug"], name: "index_thredded_private_topics_on_slug"
   end
 
   create_table "thredded_private_users", force: :cascade do |t|