Avoid hot looping on the selector for initially disconnected channels

Author: pimterry

app/src/main/java/tech/httptoolkit/android/vpn/SessionManager.java

@@ -203,7 +203,7 @@ public Session createNewUDPSession(int ip, int port, int srcIp, int srcPort){
 					SelectionKey selectionKey = channel.register(selector,
 						channel.isConnected()
 							? SelectionKey.OP_READ | SelectionKey.OP_WRITE
-							: SelectionKey.OP_CONNECT | SelectionKey.OP_READ | SelectionKey.OP_WRITE
+							: SelectionKey.OP_CONNECT
 					);
 					session.setSelectionKey(selectionKey);
 					Log.d(TAG,"Registered udp selector successfully");
@@ -289,7 +289,7 @@ public Session createNewSession(int ip, int port, int srcIp, int srcPort){
 					SelectionKey selectionKey = channel.register(selector,
 						channel.isConnected()
 							? SelectionKey.OP_READ | SelectionKey.OP_WRITE
-							: SelectionKey.OP_CONNECT | SelectionKey.OP_READ | SelectionKey.OP_WRITE
+							: SelectionKey.OP_CONNECT
 					);
 					session.setSelectionKey(selectionKey);
 					Log.d(TAG,"Registered tcp selector successfully");

app/src/main/java/tech/httptoolkit/android/vpn/socket/SocketNIODataService.java

@@ -195,14 +195,14 @@ private void processTCPSelectionKey(SelectionKey key) throws IOException{
 				session.setConnected(connected);
 				Log.d(TAG,"connected immediately to remote tcp server: "+ips+":"+port);
 			} else {
-				if(channel.isConnectionPending()){
+				if (channel.isConnectionPending()) {
 					connected = channel.finishConnect();
 					session.setConnected(connected);
 					Log.d(TAG,"connected to remote tcp server: "+ips+":"+port);
 				}
 			}
 		}
-		if(channel.isConnected()){
+		if (channel.isConnected()) {
 			// Once connected, we no longer want connect events; we want read events instead.
 			session.unsubscribeKey(SelectionKey.OP_CONNECT);
 			session.subscribeKey(SelectionKey.OP_READ);