#50 - Better account for annotation attributes without default values

sebersole · sebersole · commit 158bebec88ba · 2024-03-21T08:17:13.000-05:00
diff --git a/src/test/java/org/hibernate/models/annotations/DefaultValueTests.java b/src/test/java/org/hibernate/models/annotations/DefaultValueTests.java
@@ -68,7 +68,9 @@ private void doTest(Index index) {
 		assertThat( annotationUsage.getClassDetails( "someClassValue" ) ).isNotNull();
 		assertThat( annotationUsage.getClassDetails( "someClassValue" ).toJavaClass() ).isEqualTo( Entity.class );
 
+		// apparently the models code does not use this method directly, but ORM does.  This is the one that was leading to NPE
 		final MutableAnnotationUsage<CustomAnnotation> created = descriptor.createUsage( null, buildingContext );
+		assertThat( created.getClassDetails( "someClassValue" ) ).isNull();
 	}
 
 	@Target( ElementType.TYPE )

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ private void doTest(Index index) {`
`68`	`68`	`assertThat( annotationUsage.getClassDetails( "someClassValue" ) ).isNotNull();`
`69`	`69`	`assertThat( annotationUsage.getClassDetails( "someClassValue" ).toJavaClass() ).isEqualTo( Entity.class );`
`70`	`70`
	`71`	`+ // apparently the models code does not use this method directly, but ORM does. This is the one that was leading to NPE`
`71`	`72`	`final MutableAnnotationUsage<CustomAnnotation> created = descriptor.createUsage( null, buildingContext );`
	`73`	`+ assertThat( created.getClassDetails( "someClassValue" ) ).isNull();`
`72`	`74`	`}`
`73`	`75`
`74`	`76`	`@Target( ElementType.TYPE )`