From e742a4d6261bf81ce23a09447023b26a0efff501 Mon Sep 17 00:00:00 2001
From: Max Baumann <max@bmn.dev>
Date: Mon, 10 Apr 2023 14:16:27 +0200
Subject: [PATCH] chore: arm versioning

This reverts commit d524afdbcf0e1d9442e6bc5d7597f59cb5ac51c6.
---
 .github/workflows/buf.yaml          | 7 +++----
 .github/workflows/publish-bufs.yaml | 9 +++------
 README.md                           | 6 ------
 3 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/buf.yaml b/.github/workflows/buf.yaml
index e7a20fff4..5b76d4a9d 100644
--- a/.github/workflows/buf.yaml
+++ b/.github/workflows/buf.yaml
@@ -42,7 +42,6 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: bufbuild/buf-setup-action@v1
-# TODO (arm-versioning): Arm versioning by removing the comments of the following lines
-#      - uses: bufbuild/buf-breaking-action@v1
-#        with:
-#          against: 'https://github.com/${{ github.repository }}.git#branch=main'
+      - uses: bufbuild/buf-breaking-action@v1
+        with:
+          against: 'https://github.com/${{ github.repository }}.git#branch=main'
diff --git a/.github/workflows/publish-bufs.yaml b/.github/workflows/publish-bufs.yaml
index aa9b378b0..9415a76b9 100644
--- a/.github/workflows/publish-bufs.yaml
+++ b/.github/workflows/publish-bufs.yaml
@@ -20,13 +20,11 @@ jobs:
         fetch-depth: 2
     - uses: bufbuild/buf-setup-action@v1
     - uses: bufbuild/buf-lint-action@v1
-    # TODO (arm-versioning): Arm versioning by remove the comment of ONLY the next line
-    # - name: Check for illegal breakage
+    - name: Check for illegal breakage
       # Only deletions are allowed. Breaking updates must happen in a new version of the package(s) in question.
       # This is just a sanity check!
       # For example it allows you to delete files from the latest version of a package (depending on context that might even be ok).
-      # TODO (arm-versioning): Arm versioning by remove the comment of the next line
-      # run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
+      run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
     - name: Has breakage?
       id: breaking
       # We previously checked if any illegal breakage occurred, now check if we have breakage _at all_
@@ -52,8 +50,7 @@ jobs:
       run: |
         BUMP="patch"
         if [ "$BREAKING" = "true" ]; then
-          # TODO (arm-versioning): Arm versioning by replacing the following "minor" with "major"
-          BUMP="minor"
+          BUMP="major"
         elif [ "$NEW_PKG" = "true" ]; then
           BUMP="minor"
         else
diff --git a/README.md b/README.md
index 4736aec50..cecfd1e0c 100644
--- a/README.md
+++ b/README.md
@@ -20,9 +20,3 @@ In the context of a service directory you should be able to use
 ```
 to build the corresponding docker image as well.
 
-## Temporary advises
-
-### Arm versioning
-
-[We disarmed the versioning for pre-production.](https://github.com/helpwave/services/issues/125).
-To arm the versioning, search for "arm-versioning" in the codebase.