Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Express and expect declared as runtime dependencies #89

@jekh

Description

@jekh

I noticed when upgrading hellosign-sdk recently that express and expect are both declared as depedencies, rather than devDependencies. This causes a lot of unwanted runtime deps to get pulled into apps that use hellosign-sdk.

It looks like expect is only used in tests, but express is used in server.js for what looks like a Hello World example. Maybe server.js should move into the test/ folder, if it's used at all?

I'm happy to put together a quick PR, too.

 "dependencies": {
    "expect": "^24.9.0",
    "express": "^4.17.1",
    "form-data": "^2.3.2",
    "when": "~3.1.0"
  },

Metadata

Metadata

Assignees

No one assigned

    Labels

    legacyRelated to legacy, non-OpenAPI SDK

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions