Use FastAPI validation tricks

[hbusul]

In backend/apps/task/semester_routers.py, line 42 we have

  if (
        semester["dLesson"] < 0
        or semester["dBreak"] < 0
        or semester["slotCount"] < 3
        or semester["slotCount"] > 15
    ):

We should always validate user inputs before we process them. But it might be cleaner to do it using FastAPI features.
Here is the page describing validating body fields.
So instead of validating things in the function, we can validate things in the model and delegate FastAPI to do that.

In the model, it might be something like

dLesson: int = Field(..., gt=0)

They also mention the same tricks apply to query and path parameters.

[hbusul]

Why is this issue closed?

In backend/apps/task/semester_routers.py line 44 we still have

 if (
        len(resStartHour) != 2
        or int(resStartHour[0]) < 0
        or int(resStartHour[0]) > 23
        or int(resStartHour[1]) < 0
        or int(resStartHour[1]) > 59
    ):

We are still checking the input in create_semester and not using Fast API validation stuff. I'm reopening this issue, if there are commits that you forgot to push, please push them and close this issue.

[hbusul]

I see that problem happens because hour input is a string but I guess we can handle this later. So closing the issue again.