From b9d1f7ebb757677e23484fddf1dfbcc68c566855 Mon Sep 17 00:00:00 2001 From: Devashish Date: Wed, 28 May 2025 16:55:22 -0400 Subject: [PATCH 1/2] chore: update pull request template for PCI --- .github/PULL_REQUEST_TEMPLATE.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0d51432..1ae2196 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -**DELETE THIS TEMPLATE BEFORE SUBMITTING** +**DELETE THIS PART BEFORE SUBMITTING** In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a PR, and understand the lifecycle @@ -6,12 +6,23 @@ of a Packer Plugin PR: https://github.com/hashicorp/packer-plugin-cloudstack/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request -Describe the change you are making here! +---- -Please include tests. We recommend looking at existing tests as an example. +### :hammer_and_wrench: Description +What code changed, and why? + +### :link: Resolved Issues If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged: Closes #xxx Closes #xxx +### PCI review checklist + +- [ ] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request. +- [ ] If applicable, I've worked with GRC to document the impact of any changes to security controls. + Examples of changes to controls include access controls, encryption, logging, etc. +- [ ] If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment. + Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc. + From f7dace53b10f0ae5204acfac83a04782e7db906f Mon Sep 17 00:00:00 2001 From: Devashish Date: Wed, 28 May 2025 23:24:01 -0400 Subject: [PATCH 2/2] chore: update pull request template for PCI --- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1ae2196..63f3b74 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,21 +8,22 @@ https://github.com/hashicorp/packer-plugin-cloudstack/blob/main/.github/CONTRIBU ---- -### :hammer_and_wrench: Description +### Description What code changed, and why? -### :link: Resolved Issues +### Resolved Issues If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged: Closes #xxx Closes #xxx -### PCI review checklist -- [ ] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request. -- [ ] If applicable, I've worked with GRC to document the impact of any changes to security controls. - Examples of changes to controls include access controls, encryption, logging, etc. -- [ ] If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment. - Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc. +### Rollback Plan + +If a change needs to be reverted, we will roll out an update to the code within 7 days. + +### Changes to Security Controls + +Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.