From bc5404ef28bd92f3237e178cee15e126d48230d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Sat, 6 Dec 2025 16:12:27 -0300 Subject: [PATCH 1/2] Enable networkidle2 tests --- .../TestExpectations.local.json | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index 586709bf6..777e8f718 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -112,21 +112,6 @@ "FAIL" ] }, - { - "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[browser.spec] *should not return child_process for remote browser*", - "platforms": [ - "darwin", - "linux", - "win32" - ], - "parameters": [ - "webDriverBiDi" - ], - "expectations": [ - "FAIL" - ] - }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation*should work with clicking on anchor links", @@ -202,21 +187,6 @@ "FAIL" ] }, - { - "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[navigation.spec] *should navigate to empty page with networkidle2*", - "platforms": [ - "darwin", - "linux", - "win32" - ], - "parameters": [ - "webDriverBiDi" - ], - "expectations": [ - "FAIL" - ] - }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", "testIdPattern": "[navigation.spec] *should navigate to empty page with networkidle0*", From 4359856c536fd4f931ce8a6a083edbcee3845991 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Sun, 7 Dec 2025 20:44:10 -0300 Subject: [PATCH 2/2] ignore failing test --- .../TestExpectations/TestExpectations.local.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index 777e8f718..277600141 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -1237,5 +1237,21 @@ "expectations": [ "SKIP" ] + }, + { + "comment": "Firefox BiDi doesn't support multiple sessions on the same browser", + "testIdPattern": "[browser.spec] Browser.process should not return child_process for remote browser", + "platforms": [ + "darwin", + "linux", + "win32" + ], + "parameters": [ + "firefox", + "webDriverBiDi" + ], + "expectations": [ + "SKIP" + ] } ]