Bidi setUserAgent (#3020)

Author: kblok

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -1012,21 +1012,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[page.spec] *Page.setUserAgent*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[page.spec] *Page.url*",

lib/PuppeteerSharp/Bidi/BidiHttpRequest.cs

@@ -62,7 +62,17 @@ private BidiHttpRequest(Request request, BidiFrame frame, BidiHttpRequest redire
     internal bool HasInternalHeaderOverwrite => ExtraHttpHeaders.Values.Count != 0 || UserAgentHeaders.Values.Count != 0;
 
     /// <inheritdoc />
-    public override Task ContinueAsync(Payload payloadOverrides = null, int? priority = null) => throw new NotImplementedException();
+    public override async Task ContinueAsync(Payload payloadOverrides = null, int? priority = null)
+    {
+        // Merge the original request headers with extra headers and user agent headers
+        var mergedHeaders = GetMergedHeaders(payloadOverrides?.Headers);
+        var bidiHeaders = ConvertToBidiHeaders(mergedHeaders);
+
+        await _request.ContinueRequestAsync(
+            url: payloadOverrides?.Url,
+            method: payloadOverrides?.Method?.ToString(),
+            headers: bidiHeaders?.Count > 0 ? bidiHeaders : null).ConfigureAwait(false);
+    }
 
     /// <inheritdoc />
     public override Task RespondAsync(ResponseData response, int? priority = null) => throw new NotImplementedException();
@@ -80,14 +90,67 @@ internal static BidiHttpRequest From(Request bidiRequest, BidiFrame frame, BidiH
         return request;
     }
 
-    internal override Task FinalizeInterceptionsAsync()
+    internal override async Task FinalizeInterceptionsAsync()
     {
-        // TODO: Implement this
-        return Task.CompletedTask;
+        foreach (var handler in _interception.Handlers)
+        {
+            await handler().ConfigureAwait(false);
+        }
+
+        _interception.Handlers.Clear();
     }
 
     internal override void EnqueueInterceptionAction(Func<IRequest, Task> pendingHandler) => throw new NotImplementedException();
 
+    private static List<WebDriverBiDi.Network.Header> ConvertToBidiHeaders(Dictionary<string, string> headers)
+    {
+        if (headers == null || headers.Count == 0)
+        {
+            return null;
+        }
+
+        var bidiHeaders = new List<WebDriverBiDi.Network.Header>();
+        foreach (var kvp in headers)
+        {
+            bidiHeaders.Add(new WebDriverBiDi.Network.Header(kvp.Key, kvp.Value));
+        }
+
+        return bidiHeaders;
+    }
+
+    private Dictionary<string, string> GetMergedHeaders(Dictionary<string, string> overrideHeaders)
+    {
+        // Start with the original request headers
+        var headers = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+        foreach (var header in _request.Headers)
+        {
+            headers[header.Name.ToLowerInvariant()] = header.Value.Value;
+        }
+
+        // Add extra HTTP headers from the page
+        foreach (var kvp in ExtraHttpHeaders)
+        {
+            headers[kvp.Key.ToLowerInvariant()] = kvp.Value;
+        }
+
+        // Add user agent headers from the page
+        foreach (var kvp in UserAgentHeaders)
+        {
+            headers[kvp.Key.ToLowerInvariant()] = kvp.Value;
+        }
+
+        // Apply any override headers from the payload
+        if (overrideHeaders != null)
+        {
+            foreach (var kvp in overrideHeaders)
+            {
+                headers[kvp.Key.ToLowerInvariant()] = kvp.Value;
+            }
+        }
+
+        return headers;
+    }
+
     private void Initialize()
     {
         _request.Redirect += (sender, e) =>

lib/PuppeteerSharp/Bidi/BidiPage.cs

@@ -42,6 +42,7 @@ public class BidiPage : Page
     private InternalNetworkConditions _emulatedNetworkConditions;
     private TaskCompletionSource<bool> _closedTcs;
     private string _requestInterception;
+    private string _userAgentInterception;
 
     private BidiPage(BidiBrowserContext browserContext, BrowsingContext browsingContext) : base(browserContext.ScreenshotTaskQueue)
     {
@@ -287,7 +288,45 @@ public override async Task SetCacheEnabledAsync(bool enabled = true)
     public override Task EmulateMediaFeaturesAsync(IEnumerable<MediaFeatureValue> features) => throw new NotImplementedException();
 
     /// <inheritdoc />
-    public override Task SetUserAgentAsync(string userAgent, UserAgentMetadata userAgentData = null) => throw new NotImplementedException();
+    public override async Task SetUserAgentAsync(string userAgent, UserAgentMetadata userAgentData = null)
+    {
+        if (!BidiBrowser.CdpSupported && userAgentData != null)
+        {
+            throw new PuppeteerException("Current Browser does not support `userAgentMetadata`");
+        }
+
+        var enable = !string.IsNullOrEmpty(userAgent);
+
+        // Update the UserAgentHeaders dictionary
+        UserAgentHeaders.Clear();
+        if (enable)
+        {
+            UserAgentHeaders["User-Agent"] = userAgent;
+        }
+
+        // Toggle network interception for BeforeRequestSent phase
+        _userAgentInterception = await ToggleInterceptionAsync(
+            [InterceptPhase.BeforeRequestSent],
+            _userAgentInterception,
+            enable).ConfigureAwait(false);
+
+        // Override navigator.userAgent in JavaScript for all frames
+        var overrideNavigatorUserAgent = @"(userAgent) => {
+            Object.defineProperty(navigator, 'userAgent', {
+                value: userAgent,
+                configurable: true,
+            });
+        }";
+
+        var frames = Frames;
+        var tasks = new List<Task>(frames.Length);
+        foreach (var frame in frames)
+        {
+            tasks.Add(frame.EvaluateFunctionAsync(overrideNavigatorUserAgent, userAgent));
+        }
+
+        await Task.WhenAll(tasks).ConfigureAwait(false);
+    }
 
     /// <inheritdoc />
     public override async Task SetViewportAsync(ViewPortOptions viewport)

lib/PuppeteerSharp/Bidi/Core/Request.cs

@@ -21,6 +21,8 @@
 //  * SOFTWARE.
 
 using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
 using WebDriverBiDi.Network;
 
 namespace PuppeteerSharp.Bidi.Core;
@@ -74,6 +76,8 @@ public Request LastRedirect
 
     public string Url => _eventArgs.Request.Url;
 
+    public IList<ReadOnlyHeader> Headers => _eventArgs.Request.Headers;
+
     public WebDriverBiDi.Network.ResponseData Response => _response;
 
     public bool HasError => _error != null;
@@ -90,6 +94,20 @@ public void Dispose()
         IsDisposed = true;
     }
 
+    internal async Task ContinueRequestAsync(
+        string url = null,
+        string method = null,
+        List<Header> headers = null)
+    {
+        var commandParams = new ContinueRequestCommandParameters(Id)
+        {
+            Url = url,
+            Method = method,
+            Headers = headers,
+        };
+        await Session.Driver.Network.ContinueRequestAsync(commandParams).ConfigureAwait(false);
+    }
+
     private void Initialize()
     {
         _browsingContext.Closed += (sender, args) =>