Bidi Browser.IsConnected support (#3030)

Author: kblok

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -1,4 +1,11 @@
 [
+  {
+    "comment": "Test depends on ConnectAsync which is not implemented for BiDi yet - see [connect.spec] expectations",
+    "testIdPattern": "[browser.spec] Browser.isConnected should set the browser connected state",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["SKIP"]
+  },
   {
     "testIdPattern": "[network.spec] PuppeteerSharp network*",
     "platforms": ["darwin", "linux", "win32"],
@@ -97,21 +104,6 @@
     "parameters": ["firefox"],
     "expectations": ["FAIL"]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[browser.spec] *Browser.isConnected*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[browser.spec] *should not return child_process for remote browser*",

lib/PuppeteerSharp/Bidi/BidiBrowser.cs

@@ -56,6 +56,9 @@ private BidiBrowser(Core.Browser browserCore, LaunchOptions options, ILoggerFact
     /// <inheritdoc />
     public override bool IsClosed => _isClosed;
 
+    /// <inheritdoc />
+    public override bool IsConnected => !BrowserCore.IsDisconnected;
+
     /// <inheritdoc />
     public override ITarget Target => _target;
 

lib/PuppeteerSharp/Bidi/Core/Browser.cs

@@ -48,6 +48,8 @@ internal sealed class Browser(Session session) : IDisposable
 
     public bool IsClosed { get; set; }
 
+    public bool IsDisconnected => Reason != null;
+
     public string Reason { get; set; }
 
     internal UserContext DefaultUserContext => _userContexts.TryGetValue(UserContext.DEFAULT, out var context) ? context : _userContexts.Values.FirstOrDefault();

lib/PuppeteerSharp/Browser.cs

@@ -53,7 +53,7 @@ public abstract class Browser : IBrowser
         public int DefaultWaitForTimeout { get; set; } = Puppeteer.DefaultTimeout;
 
         /// <inheritdoc/>
-        public bool IsConnected => !Connection.IsClosed;
+        public virtual bool IsConnected => !Connection.IsClosed;
 
         /// <inheritdoc/>
         public virtual ITarget Target => Targets().FirstOrDefault(t => t.Type == TargetType.Browser);