Skip to content

Commit 44afae6

Browse files
committed
merged conflicts
2 parents 719ffb3 + 57ae59b commit 44afae6

22 files changed

+48
-83
lines changed

.github/workflows/fix-php-code-style-issues.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
ref: ${{ github.head_ref }}
2020

2121
- name: Fix PHP code style issues
22-
uses: aglipanci/laravel-pint-action@2.3.1
22+
uses: aglipanci/laravel-pint-action@2.4
2323

2424
- name: Commit changes
2525
uses: stefanzweifel/git-auto-commit-action@v4

src/DatatableInput.php

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,15 @@
77

88
class DatatableInput
99
{
10-
/**
11-
* @param int $start
12-
* @param int $size
13-
* @param array $filters
14-
* @param array $sorting
15-
* @param array $rels
16-
*/
1710
public function __construct(
18-
private int $start,
19-
private ?int $size,
11+
private int $start,
12+
private ?int $size,
2013
private array $filters,
2114
private array $sorting,
2215
private array $rels,
2316
private array $allowedFilters,
2417
private array $allowedSortings,
25-
)
26-
{
18+
) {
2719
}
2820

2921
public function getStart(): int
@@ -41,7 +33,7 @@ public function getSize(): ?int
4133
*/
4234
public function getFilters(): array
4335
{
44-
$filters = array();
36+
$filters = [];
4537

4638
foreach ($this->filters as $filter) {
4739
$filters[] = new Filter(
@@ -56,19 +48,14 @@ public function getFilters(): array
5648
return $filters;
5749
}
5850

59-
/**
60-
* @return Sort|null
61-
*/
6251
public function getSorting(): ?Sort
6352
{
64-
return !empty($this->sorting) ?
53+
return ! empty($this->sorting) ?
6554
new Sort($this->sorting[0]->id, $this->sorting[0]->desc, $this->allowedSortings) : null;
6655
}
6756

6857
public function getRelations(): array
6958
{
7059
return $this->rels;
7160
}
72-
73-
7461
}

src/Enums/DataType.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?php
22

33
namespace HamidRrj\LaravelDatatable\Enums;
4+
45
enum DataType: string
56
{
67
case NUMERIC = 'numeric';
@@ -9,6 +10,6 @@ enum DataType: string
910

1011
public static function values(): array
1112
{
12-
return array_column(self::cases(), 'value');
13+
return array_column(self::cases(), 'value');
1314
}
1415
}

src/Enums/SearchType.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ enum SearchType: string
1414

1515
public static function values(): array
1616
{
17-
return array_column(self::cases(), 'value');
17+
return array_column(self::cases(), 'value');
1818
}
19-
}
19+
}

src/Exceptions/InvalidFilterException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class InvalidFilterException extends Exception implements InvalidParameterInterf
88
{
99
protected $fieldName;
1010

11-
public function __construct($fieldName, $message = "", $code = 400, \Throwable $previous = null)
11+
public function __construct($fieldName, $message = '', $code = 400, ?\Throwable $previous = null)
1212
{
1313
$this->fieldName = $fieldName;
1414
parent::__construct($message, $code, $previous);

src/Exceptions/InvalidRelationException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class InvalidRelationException extends Exception implements InvalidParameterInte
88
{
99
protected $fieldName;
1010

11-
public function __construct($fieldName, $message = "", $code = 400, \Throwable $previous = null)
11+
public function __construct($fieldName, $message = '', $code = 400, ?\Throwable $previous = null)
1212
{
1313
$this->fieldName = $fieldName;
1414
parent::__construct($message, $code, $previous);

src/Exceptions/InvalidSortingException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class InvalidSortingException extends Exception implements InvalidParameterInter
88
{
99
protected $fieldName;
1010

11-
public function __construct($fieldName, $message = "", $code = 400, \Throwable $previous = null)
11+
public function __construct($fieldName, $message = '', $code = 400, ?\Throwable $previous = null)
1212
{
1313
$this->fieldName = $fieldName;
1414
parent::__construct($message, $code, $previous);

src/Filter/ApplyFilter.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,10 @@ class ApplyFilter
1717
{
1818
private SearchFilter $searchFilter;
1919

20-
/**
21-
* @param Builder $query
22-
* @param Filter $filter
23-
*/
2420
public function __construct(
2521
private Builder $query,
26-
private Filter $filter,
27-
)
28-
{
22+
private Filter $filter,
23+
) {
2924
}
3025

3126
public function apply(): Builder
@@ -62,10 +57,10 @@ public function apply(): Builder
6257
default:
6358
$searchFunction = $filter->getFn();
6459
throw new InvalidFilterException($searchFunction, "search function `$searchFunction` is invalid.");
65-
6660
}
6761

6862
$relation = $this->filter->getRelation();
63+
6964
return $relation ? $this->applyFilterToRelation($relation) : $this->searchFilter->apply();
7065
}
7166

src/Filter/Filter.php

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,15 @@ class Filter
99
private static FilterValidator $filterValidator;
1010

1111
/**
12-
* @param string $id
13-
* @param string|int|array $value
14-
* @param string $fn
15-
* @param string $datatype
16-
* @param array $allowedFilters
1712
* @throws \HamidRrj\LaravelDatatable\Exceptions\InvalidFilterException
1813
*/
1914
public function __construct(
20-
private string $id,
15+
private string $id,
2116
private string|int|array $value,
22-
private string $fn,
23-
private string $datatype,
17+
private string $fn,
18+
private string $datatype,
2419
private array $allowedFilters
25-
)
26-
{
20+
) {
2721
self::$filterValidator = FilterValidator::getInstance();
2822
self::$filterValidator->isValid($this, $this->allowedFilters);
2923
}
@@ -51,12 +45,14 @@ public function getDatatype(): string
5145
public function getRelation(): string
5246
{
5347
$fieldArray = explode('.', $this->id);
48+
5449
return count($fieldArray) > 1 ? $fieldArray[0] : '';
5550
}
5651

5752
public function getColumn(): string
5853
{
5954
$fieldArray = explode('.', $this->id);
55+
6056
return array_pop($fieldArray);
6157
}
6258

@@ -69,5 +65,4 @@ public function setValue(int|array|string $value): void
6965
{
7066
$this->value = $value;
7167
}
72-
7368
}

src/Filter/SearchFunctions/FilterBetween.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
class FilterBetween extends SearchFilter
88
{
9-
109
public function apply(): Builder
1110
{
1211
$query = $this->query;

0 commit comments

Comments
 (0)