upgrade Bazel protobuf to 33.1 #12553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
bazel-protobuf
branch
2 times, most recently
from
81e72aa to
bbda349
Compare
benjaminp
force-pushed
the
bazel-protobuf
branch
11 times, most recently
from
6ed5d8e to
726b60e
Compare
benjaminp
force-pushed
the
bazel-protobuf
branch
from
726b60e to
d538b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on 58ae5f8, change Bazel's view of the protobuf version to 33.1 too.
This is a bit of an adventure in the bzlmod/WORKSPACE compatibility maze. A few rulesets like
rules_javamust be upgraded too.C++ compilation must happen until C++17 now due to the new abseil version required.
Dependency on
rules_protois removed because it has become a superfluous wrapper over rules in the upstream protobuf repo.