From 220475cba5a53cdb56115239aecb5c1be1496234 Mon Sep 17 00:00:00 2001
From: Eric Anderson <ejona@google.com>
Date: Wed, 19 Nov 2025 10:18:39 -0800
Subject: [PATCH] xds: Fix WRR test flake with TSAN

Fixes:
```
org.mockito.exceptions.verification.TooManyActualInvocations:
metricSink.addLongCounter(
    <custom argument matcher>,
    1L,
    [directaddress:///wrr-metrics],
    [, ]
);
Wanted 1 time:
-> at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)
But was 2 times:
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)
-> at io.grpc.internal.MetricRecorderImpl.addLongCounter(MetricRecorderImpl.java:103)

	at io.grpc.xds.WeightedRoundRobinLoadBalancerTest.metricWithRealChannel(WeightedRoundRobinLoadBalancerTest.java:1307)
```
---
 .../java/io/grpc/xds/WeightedRoundRobinLoadBalancerTest.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xds/src/test/java/io/grpc/xds/WeightedRoundRobinLoadBalancerTest.java b/xds/src/test/java/io/grpc/xds/WeightedRoundRobinLoadBalancerTest.java
index 868bc811a70..9fac46eaf09 100644
--- a/xds/src/test/java/io/grpc/xds/WeightedRoundRobinLoadBalancerTest.java
+++ b/xds/src/test/java/io/grpc/xds/WeightedRoundRobinLoadBalancerTest.java
@@ -21,6 +21,7 @@
 import static org.mockito.AdditionalAnswers.delegatesTo;
 import static org.mockito.ArgumentMatchers.argThat;
 import static org.mockito.Mockito.any;
+import static org.mockito.Mockito.atLeast;
 import static org.mockito.Mockito.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
@@ -1303,8 +1304,8 @@ public void metricWithRealChannel() throws Exception {
     assertThat(recorder.getError()).isNull();
 
     // Make sure at least one metric works. The other tests will make sure other metrics and the
-    // edge cases are working.
-    verify(metrics).addLongCounter(
+    // edge cases are working. Since this is racy, we just care it happened at least once.
+    verify(metrics, atLeast(1)).addLongCounter(
         argThat((instr) -> instr.getName().equals("grpc.lb.wrr.rr_fallback")),
         eq(1L),
         eq(Arrays.asList("directaddress:///wrr-metrics")),