Deprecate FrozenDict/List, use tuples as node lists

These utility classes were a bit awkward and e.g. caused problems
with pickle since a list object is assumed to be appendable (#112).

Instead of FrozenLists, we now use homogeneous tuples to guarantee
that node lists and other collections are immutable. We also use the
Collection and Mapping types to indicate immutability.

Ordinary tuples are more lightweight and pythonic than FrozenLists.

We also exclude the links when pickling Tokens in order to make
pickling GraphQL schemas (which contain the tokens) less expensive.

Author: Cito

docs/modules/pyutils.rst

@@ -25,14 +25,6 @@ PyUtils
    :no-members:
    :no-inherited-members:
    :no-special-members:
-.. autoclass:: FrozenList
-   :no-members:
-   :no-inherited-members:
-   :no-special-members:
-.. autoclass:: FrozenDict
-   :no-members:
-   :no-inherited-members:
-   :no-special-members:
 .. autoclass:: Path
 .. autofunction:: print_path_list
 .. autoclass:: SimplePubSub

docs/modules/type.rst

@@ -122,7 +122,9 @@ Definitions
 .. autoclass:: GraphQLSkipDirective
 .. autoclass:: GraphQLDeprecatedDirective
 
-.. autodata:: specified_directives
+.. data:: specified_directives
+
+   A tuple with all directives from the GraphQL specification
 
 .. data:: DEFAULT_DEPRECATION_REASON
    :annotation: = 'No longer supported'
@@ -146,7 +148,9 @@ Definitions
 .. autoclass:: TypeNameMetaFieldDef
 .. autoclass:: SchemaMetaFieldDef
 
-.. autodata:: introspection_types
+.. data:: introspection_types
+
+   This is a mapping containing all introspection types with their names as keys
 
 
 Scalars
@@ -166,8 +170,7 @@ Definitions
 .. autoclass:: GraphQLInt
 .. autoclass:: GraphQLString
 
-The list of all specified directives is available as
-:data:`specified_directives`.
+A tuple with all specified directives is available as :data:`specified_directives`.
 
 
 Schema

docs/modules/validation.rst

@@ -29,8 +29,9 @@ Rules
 .. module:: graphql.validation.rules
 .. currentmodule:: graphql.validation
 
-.. autodata:: specified_rules
-   :annotation: = FrozenList([...])
+.. data:: specified_rules
+
+   A tuple with all validation rules defined by the GraphQL specification
 
 **Spec Section: "Executable Definitions"**
 

src/graphql/execution/execute.py

@@ -34,7 +34,6 @@
     is_awaitable as default_is_awaitable,
     is_iterable,
     AwaitableOrValue,
-    FrozenList,
     Path,
     Undefined,
 )
@@ -285,7 +284,7 @@ def build(
 
         coerced_variable_values = get_variable_values(
             schema,
-            operation.variable_definitions or FrozenList(),
+            operation.variable_definitions or (),
             raw_variable_values or {},
             max_errors=50,
         )

src/graphql/execution/values.py

@@ -1,4 +1,4 @@
-from typing import Any, Callable, Dict, List, Optional, Union, cast
+from typing import Any, Callable, Collection, Dict, List, Optional, Union, cast
 
 from ..error import GraphQLError
 from ..language import (
@@ -17,7 +17,7 @@
     VariableNode,
     print_ast,
 )
-from ..pyutils import inspect, print_path_list, FrozenList, Undefined
+from ..pyutils import inspect, print_path_list, Undefined
 from ..type import (
     GraphQLDirective,
     GraphQLField,
@@ -38,7 +38,7 @@
 
 def get_variable_values(
     schema: GraphQLSchema,
-    var_def_nodes: FrozenList[VariableDefinitionNode],
+    var_def_nodes: Collection[VariableDefinitionNode],
     inputs: Dict[str, Any],
     max_errors: Optional[int] = None,
 ) -> CoercedVariableValues:
@@ -72,7 +72,7 @@ def on_error(error: GraphQLError) -> None:
 
 def coerce_variable_values(
     schema: GraphQLSchema,
-    var_def_nodes: FrozenList[VariableDefinitionNode],
+    var_def_nodes: Collection[VariableDefinitionNode],
     inputs: Dict[str, Any],
     on_error: Callable[[GraphQLError], None],
 ) -> Dict[str, Any]: