schema: fix error message when provided type has no name

Replicates graphql/graphql-js@63c2009

Author: Cito

src/graphql/type/schema.py

@@ -230,6 +230,11 @@ def __init__(
                 continue
 
             type_name = getattr(named_type, "name", None)
+            if not type_name:
+                raise TypeError(
+                    "One of the provided types for building the Schema"
+                    " is missing a name.",
+                )
             if type_name in type_map:
                 raise TypeError(
                     "Schema must contain uniquely named types"

tests/type/test_schema.py

@@ -23,6 +23,7 @@
     GraphQLScalarType,
     GraphQLSchema,
     GraphQLString,
+    GraphQLType,
     specified_directives,
 )
 from graphql.utilities import print_schema
@@ -243,7 +244,7 @@ def includes_input_types_only_used_in_directives():
             assert "Foo" in schema.type_map
             assert "Bar" in schema.type_map
 
-    def preserves_order_of_user_provided_types():
+    def preserves_the_order_of_user_provided_types():
         a_type = GraphQLObjectType(
             "A", {"sub": GraphQLField(GraphQLScalarType("ASub"))}
         )
@@ -341,6 +342,17 @@ def rejects_a_schema_which_redefines_a_built_in_type():
                 f" but contains multiple types named 'String'."
             )
 
+        def rejects_a_schema_when_a_provided_type_has_no_name():
+            query = GraphQLObjectType("Query", {"foo": GraphQLField(GraphQLString)})
+            types = [GraphQLType(), query, GraphQLType()]
+
+            with raises(TypeError) as exc_info:
+                GraphQLSchema(query, types=types)  # type: ignore
+            msg = str(exc_info.value)
+            assert msg == (
+                "One of the provided types for building the Schema is missing a name."
+            )
+
         def rejects_a_schema_which_defines_an_object_twice():
             types = [
                 GraphQLObjectType("SameName", {}),

tests/type/test_validation.py

@@ -102,6 +102,12 @@ def with_modifiers(
     *with_modifiers(SomeInterfaceType),
 ]
 
+not_graphql_types = [
+    type("IntType", (int,), {"name": "IntType"}),
+    type("FloatType", (float,), {"name": "FloatType"}),
+    type("StringType", (str,), {"name": "StringType"}),
+]
+
 parametrize_type = partial(
     mark.parametrize("type_", ids=lambda type_: type_.__class__.__name__)
 )
@@ -1044,7 +1050,7 @@ def rejects_a_non_output_type_as_an_object_field_type(type_):
             }
         ]
 
-    @parametrize_type([int, float, str])
+    @parametrize_type(not_graphql_types)
     def rejects_a_non_type_value_as_an_object_field_type(type_):
         schema = _schema_with_object_field_of_type(type_)
         assert validate_schema(schema) == [
@@ -1372,7 +1378,7 @@ def rejects_a_non_output_type_as_an_interface_field_type(type_):
             },
         ]
 
-    @parametrize_type([int, float, str])
+    @parametrize_type(not_graphql_types)
     def rejects_a_non_type_value_as_an_interface_field_type(type_):
         schema = _schema_with_interface_field_of_type(type_)
         assert validate_schema(schema) == [
@@ -1525,7 +1531,7 @@ def rejects_a_non_input_type_as_a_field_arg_type(type_):
             },
         ]
 
-    @parametrize_type([int, float, str])
+    @parametrize_type(not_graphql_types)
     def rejects_a_non_type_value_as_a_field_arg_type(type_):
         schema = _schema_with_arg_of_type(type_)
         assert validate_schema(schema) == [
@@ -1635,7 +1641,7 @@ def rejects_a_non_input_type_as_an_input_field_type(type_):
             }
         ]
 
-    @parametrize_type([int, float, str])
+    @parametrize_type(not_graphql_types)
     def rejects_a_non_type_value_as_an_input_field_type(type_):
         schema = _schema_with_input_field_of_type(type_)
         assert validate_schema(schema) == [