Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 7d565c9

Browse files
author
Bruno Rodrigues
committed
Fix tests for tracing instrumentation being create at the same time as metrics instrumentation
1 parent c874bcd commit 7d565c9

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/GraphQLInstrumentationAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class GraphQLInstrumentationAutoConfiguration {
3636
private Boolean tracingEnabled;
3737

3838
@Bean
39-
@ConditionalOnMissingBean
39+
@ConditionalOnMissingBean({TracingInstrumentation.class, MetricsInstrumentation.class})
4040
@ConditionalOnProperty(value = "graphql.servlet.tracing-enabled", havingValue = "true")
4141
public TracingInstrumentation tracingInstrumentation() {
4242
return new TracingInstrumentation();

graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/metrics/MetricsInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.oembedler.moon.graphql.boot.metrics;
22

33
import graphql.ExecutionResult;
4-
import graphql.execution.instrumentation.SimpleInstrumentation;
54
import graphql.execution.instrumentation.parameters.InstrumentationExecutionParameters;
5+
import graphql.execution.instrumentation.tracing.TracingInstrumentation;
66
import io.micrometer.core.instrument.MeterRegistry;
77
import io.micrometer.core.instrument.Timer;
88

@@ -14,7 +14,7 @@
1414
/**
1515
* @author Bruno Rodrigues
1616
*/
17-
public class MetricsInstrumentation extends SimpleInstrumentation {
17+
public class MetricsInstrumentation extends TracingInstrumentation {
1818

1919
private MeterRegistry meterRegistry;
2020

graphql-spring-boot-autoconfigure/src/test/java/com/oembedler/moon/graphql/boot/test/instrumentation/GraphQLInstrumentationAutoConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ public void maxQueryDepthEnabled() {
7171
Assert.assertNotNull(this.getContext().getBean(MaxQueryDepthInstrumentation.class));
7272
}
7373

74-
@Test
74+
@Test(expected = NoSuchBeanDefinitionException.class)
7575
public void actuatorMetricsEnabledAndTracingEnabled() {
7676
load(DefaultConfiguration.class, "graphql.servlet.tracing-enabled=true", "graphql.servlet.actuator-metrics=true");
7777

7878
Assert.assertNotNull(this.getContext().getBean(TracingInstrumentation.class));
79-
Assert.assertNotNull(this.getContext().getBean(MetricsInstrumentation.class));
79+
this.getContext().getBean(TracingInstrumentation.class);
8080
}
8181

8282
@Test

0 commit comments

Comments
 (0)