♻️ Refactored tests and added universal remove nod

Author: aexol

package.json

@@ -1,6 +1,6 @@
 {
   "name": "graphql-js-tree",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "private": false,
   "license": "MIT",
   "description": "GraphQL Parser providing simplier structure",

src/TreeOperations/tree.ts

@@ -124,7 +124,7 @@ export const mutate = (tree: ParserTree, allNodes: ParserField[]) => {
         const parentDirective = parent.directives.find((d) => d.args.some((a) => a === node));
         if (parentDirective) {
           const indexInDirective = parentDirective.args.indexOf(node);
-          deleteFieldFromNode(parent, indexInDirective);
+          deleteFieldFromNode(parentDirective, indexInDirective);
         }
       }
       return;

src/__tests__/TreeOperations/mocks.ts

@@ -8,6 +8,7 @@ import {
   createPlainDirectiveImplementation,
   createPlainArgument,
   createPlainEnumValue,
+  createUnionMember,
 } from '@/shared';
 
 const mainMock: ParserTree = {
@@ -121,6 +122,15 @@ const mainMock: ParserTree = {
         }),
       ],
     }),
+    createRootField({
+      name: 'AnUnion',
+      type: TypeDefinition.UnionTypeDefinition,
+      args: [
+        createUnionMember({ name: 'Car' }),
+        createUnionMember({ name: 'Ship' }),
+        createUnionMember({ name: 'Plane' }),
+      ],
+    }),
     createRootDirectiveField({
       name: 'model',
       args: [createPlainInputValue({ name: 'maxAge', type: ScalarTypes.Int })],

src/__tests__/TreeOperations/tree.remove.spec.ts

@@ -50,13 +50,20 @@ describe('Tree Operations - node removal tests', () => {
   });
   test('Delete argument node from Directive Instance', () => {
     const treeMock = createMock();
-    const oldFieldId = treeMock.nodes[1].args[1].id;
-    const oldQueryId = treeMock.nodes[1].id;
-    const oldInputValue = JSON.parse(JSON.stringify(treeMock.nodes[1].args[1].args[0]));
-    mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[1].args[1].args[0]);
-
-    expect(treeMock.nodes[1].args[1].args).not.toContainEqual(oldInputValue);
-    expect(treeMock.nodes[1].args[1].id).not.toEqual(oldFieldId);
-    expect(treeMock.nodes[1].id).not.toEqual(oldQueryId);
+    const oldArgument = JSON.parse(JSON.stringify(treeMock.nodes[0].directives[0].args[0]));
+    mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[0].directives[0].args[0]);
+    expect(treeMock.nodes[0].directives[0].args).not.toContainEqual(oldArgument);
+  });
+  test('Delete union member from union node', () => {
+    const treeMock = createMock();
+    const oldArgument = JSON.parse(JSON.stringify(treeMock.nodes[4].args[0]));
+    mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[4].args[0]);
+    expect(treeMock.nodes[3].args).not.toContainEqual(oldArgument);
+  });
+  test('Delete enum value from enum node', () => {
+    const treeMock = createMock();
+    const oldArgument = JSON.parse(JSON.stringify(treeMock.nodes[3].args[0]));
+    mutate(treeMock, treeMock.nodes).removeNode(treeMock.nodes[3].args[0]);
+    expect(treeMock.nodes[3].args).not.toContainEqual(oldArgument);
   });
 });