Skip to content

Commit 8250fb8

Browse files
committed
Cleanup
1 parent 8c4ce64 commit 8250fb8

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

src/__mocks__/userModel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ const UserSchema = new Schema(
8686
);
8787

8888
UserSchema.set('autoIndex', false);
89-
UserSchema.index({ name: 1, totalExperience: -1 });
89+
UserSchema.index({ name: 1, age: -1 });
9090

9191
UserSchema.virtual('nameVirtual').get(function () { // eslint-disable-line
9292
return `VirtualFieldValue${this._id}`;

src/definition.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ export type sortHelperArgsOpts = {
109109

110110
export type inputHelperArgsOpts = {
111111
inputTypeName?: string,
112-
removeFields?: string | string[],
113-
requiredFields?: string | string[],
112+
removeFields?: string[],
113+
requiredFields?: string[],
114114
isRequired?: boolean,
115115
};
116116

src/resolvers/__tests__/findById-test.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ import findById from '../findById';
66
import Resolver from '../../../../graphql-compose/src/resolver/resolver';
77
import { GraphQLNonNull } from 'graphql';
88
import GraphQLMongoID from '../../types/mongoid';
9+
import { convertModelToGraphQL } from '../../fieldsConverter';
10+
11+
const UserType = convertModelToGraphQL(UserModel, 'User');
912

1013
describe('findById() ->', () => {
1114
let user;
@@ -22,13 +25,13 @@ describe('findById() ->', () => {
2225
});
2326

2427
it('should return Resolver object', () => {
25-
const resolver = findById(UserModel);
28+
const resolver = findById(UserModel, UserType);
2629
expect(resolver).to.be.instanceof(Resolver);
2730
});
2831

2932
describe('Resolver.args', () => {
3033
it('should have non-null `_id` arg', () => {
31-
const resolver = findById(UserModel);
34+
const resolver = findById(UserModel, UserType);
3235
expect(resolver.hasArg('_id')).to.be.true;
3336
const argConfig = resolver.getArg('_id');
3437
expect(argConfig).property('type').that.instanceof(GraphQLNonNull);
@@ -38,22 +41,22 @@ describe('findById() ->', () => {
3841

3942
describe('Resolver.resolve():Promise', () => {
4043
it('should be fulfilled promise', async () => {
41-
const result = findById(UserModel).resolve({});
44+
const result = findById(UserModel, UserType).resolve({});
4245
await expect(result).be.fulfilled;
4346
});
4447

4548
it('should be rejected if args.id is not objectId', async () => {
46-
const result = findById(UserModel).resolve({ args: { _id: 1 } });
49+
const result = findById(UserModel, UserType).resolve({ args: { _id: 1 } });
4750
await expect(result).be.rejected;
4851
});
4952

5053
it('should return null if args.id is empty', async () => {
51-
const result = await findById(UserModel).resolve({});
54+
const result = await findById(UserModel, UserType).resolve({});
5255
expect(result).equal(null);
5356
});
5457

5558
it('should return document if provided existed id', async () => {
56-
const result = await findById(UserModel).resolve({ args: { _id: user._id } });
59+
const result = await findById(UserModel, UserType).resolve({ args: { _id: user._id } });
5760
expect(result).have.property('name').that.equal(user.name);
5861
});
5962
});

src/resolvers/__tests__/findByIds-test.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@ import { expect } from 'chai';
44
import { UserModel } from '../../__mocks__/userModel.js';
55
import findByIds from '../findByIds';
66
import Resolver from '../../../../graphql-compose/src/resolver/resolver';
7-
import { GraphQLNonNull, GraphQLList, GraphQLObjectType } from 'graphql';
7+
import { GraphQLNonNull, GraphQLList } from 'graphql';
88
import GraphQLMongoID from '../../types/mongoid';
9+
import { convertModelToGraphQL } from '../../fieldsConverter';
910

10-
const UserType = new GraphQLObjectType({
11-
name: 'MockUserType',
12-
});
11+
const UserType = convertModelToGraphQL(UserModel, 'User');
1312

1413
describe('findByIds() ->', () => {
1514
let user1;

src/resolvers/__tests__/findMany-test.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ import { expect } from 'chai';
44
import { UserModel } from '../../__mocks__/userModel.js';
55
import findMany from '../findMany';
66
import Resolver from '../../../../graphql-compose/src/resolver/resolver';
7-
import { GraphQLObjectType } from 'graphql';
7+
import { convertModelToGraphQL } from '../../fieldsConverter';
88

9-
const UserType = new GraphQLObjectType({
10-
name: 'MockUserType',
11-
});
9+
const UserType = convertModelToGraphQL(UserModel, 'User');
1210

1311

1412
describe('findMany() ->', () => {

src/resolvers/__tests__/updateById-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { UserModel } from '../../__mocks__/userModel.js';
55
import updateById from '../updateById';
66
import Resolver from '../../../../graphql-compose/src/resolver/resolver';
77
import TypeComposer from '../../../../graphql-compose/src/typeComposer';
8-
import InputTypeComposer from '../../../../graphql-compose/src/typeInputComposer';
8+
import InputTypeComposer from '../../../../graphql-compose/src/inputTypeComposer';
99
import { convertModelToGraphQL } from '../../fieldsConverter';
1010
import {
1111
GraphQLNonNull,

0 commit comments

Comments
 (0)