groupBy: support non-strings (#283)

tombrk · web-flow · commit b8e4e44eeffe · 2022-07-13T18:31:22.000+02:00
previously, group-by coerced all values into strings for comparison, but
only for the left-hand side, effectively resulting into groupBy being
only usable with strings.

by changing the set type to literal "any", this limitation is removed.
diff --git a/src/datasource.ts b/src/datasource.ts
@@ -265,7 +265,7 @@ export const groupBy = (frame: DataFrame, fieldName: string): DataFrame[] => {
     return [frame];
   }
 
-  const uniqueValues = new Set<string>(groupByField.values.toArray().map((value) => value.toString()));
+  const uniqueValues = new Set(groupByField.values.toArray());
 
   const frames = [...uniqueValues].map((groupByValue) => {
     const fields: Field[] = frame.fields

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ export const groupBy = (frame: DataFrame, fieldName: string): DataFrame[] => {`
`265`	`265`	`return [frame];`
`266`	`266`	`}`
`267`	`267`
`268`		`- const uniqueValues = new Set<string>(groupByField.values.toArray().map((value) => value.toString()));`
	`268`	`+ const uniqueValues = new Set(groupByField.values.toArray());`
`269`	`269`
`270`	`270`	`const frames = [...uniqueValues].map((groupByValue) => {`
`271`	`271`	`const fields: Field[] = frame.fields`