Skip to content

Commit 92c54d2

Browse files
connecting it up
1 parent 2f0b2ad commit 92c54d2

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

playground/internal/react/bannerTitle.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@ func bannerTitleComponent(props Props) *Element {
1616
`id`: `banner-title-sub`,
1717
},
1818
// TODO(grantnelson-wf): Make this a link to the gopherjs repo
19+
// https://github.com/gopherjs/gopherjs
1920
`GopherJS `,
2021
),
2122
Span(Props{
2223
`id`: `banner-title-version`,
2324
},
2425
// TODO(grantnelson-wf): Make this version a link to release notes
26+
// https://github.com/gopherjs/gopherjs/releases/tag/v1.19.0-beta2
2527
`(`+version+`)`,
2628
),
2729
)

playground/internal/react/codeBox.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ func (cba *codeBoxAssistant) onKeyDown(e *js.Object) {
6868
// TODO(grantnelson-wf): Handle Ctrl+/ for commenting/uncommenting the current line or selection.
6969
// TODO(grantnelson-wf): Handle Ctrl+S for saving the code, just run formatting, or just ignore it.
7070
// TODO(grantnelson-wf): Maybe handle auto-text like `/*` adds `*/`, `"` adds another `"`, `[` adds `]`, etc.
71+
// TODO(grantnelson-wf): If possible, make escape focus out of the code box since tabs won't switch focus anymore.
7172
if cba.handleKeyDown(e.Get(`keyCode`).Int()) {
7273
e.Call(`preventDefault`)
7374
}

playground/internal/react/shareUrlControl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func shareUrlComponent(props Props) *Element {
4040
`type`: `text`,
4141
`className`: className,
4242
`ref`: shareUrlRef,
43-
`value`: `https://localhost:8080#/2523432342`, //shareUrl, // TODO(grantnelson-wf): FIX
43+
`value`: shareUrl,
4444
`readOnly`: true,
4545
`onFocus`: onShareUrlFocus,
4646
}),

0 commit comments

Comments
 (0)