chore: groups revive files to a package

Author: ldez

pkg/golinters/revive.go pkg/golinters/revive/revive.gopkg/golinters/revive.go renamed to pkg/golinters/revive/revive.go

@@ -1,4 +1,4 @@
-package golinters
+package revive
 
 import (
 	"bytes"
@@ -23,20 +23,17 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-const reviveName = "revive"
+const name = "revive"
 
-var reviveDebugf = logutils.Debug(logutils.DebugKeyRevive)
+var debugf = logutils.Debug(logutils.DebugKeyRevive)
 
 // jsonObject defines a JSON object of a failure
 type jsonObject struct {
 	Severity     lint.Severity
 	lint.Failure `json:",inline"`
 }
 
-// NewRevive returns a new Revive linter.
-//
-
-func NewRevive(settings *config.ReviveSettings) *goanalysis.Linter {
+func New(settings *config.ReviveSettings) *goanalysis.Linter {
 	var mu sync.Mutex
 	var resIssues []goanalysis.Issue
 
@@ -47,7 +44,7 @@ func NewRevive(settings *config.ReviveSettings) *goanalysis.Linter {
 	}
 
 	return goanalysis.NewLinter(
-		reviveName,
+		name,
 		"Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint.",
 		[]*analysis.Analyzer{analyzer},
 		nil,
@@ -154,7 +151,7 @@ func reviveToIssue(pass *analysis.Pass, object *jsonObject) goanalysis.Issue {
 			From: object.Position.Start.Line,
 			To:   lineRangeTo,
 		},
-		FromLinter: reviveName,
+		FromLinter: name,
 	}, pass)
 }
 
@@ -192,7 +189,7 @@ func getReviveConfig(cfg *config.ReviveSettings) (*lint.Config, error) {
 		conf.Rules[k] = r
 	}
 
-	reviveDebugf("revive configuration: %#v", conf)
+	debugf("revive configuration: %#v", conf)
 
 	return conf, nil
 }

pkg/golinters/revive/revive_integration_test.go

@@ -0,0 +1,11 @@
+package revive
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

test/testdata/revive.go pkg/golinters/revive/testdata/revive.gotest/testdata/revive.go renamed to pkg/golinters/revive/testdata/revive.go

@@ -1,5 +1,5 @@
 //golangcitest:args -Erevive
-//golangcitest:config_path testdata/configs/revive.yml
+//golangcitest:config_path testdata/revive.yml
 package testdata
 
 import (

test/testdata/configs/revive.yml pkg/golinters/revive/testdata/revive.ymltest/testdata/configs/revive.yml renamed to pkg/golinters/revive/testdata/revive.yml

@@ -84,6 +84,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/promlinter"
 	"github.com/golangci/golangci-lint/pkg/golinters/protogetter"
 	"github.com/golangci/golangci-lint/pkg/golinters/reassign"
+	"github.com/golangci/golangci-lint/pkg/golinters/revive"
 	"github.com/golangci/golangci-lint/pkg/golinters/spancheck"
 	"github.com/golangci/golangci-lint/pkg/golinters/tagalign"
 	"github.com/golangci/golangci-lint/pkg/golinters/whitespace"
@@ -625,7 +626,7 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/curioswitch/go-reassign"),
 
-		linter.NewConfig(golinters.NewRevive(&cfg.LintersSettings.Revive)).
+		linter.NewConfig(revive.New(&cfg.LintersSettings.Revive)).
 			WithSince("v1.37.0").
 			WithPresets(linter.PresetStyle, linter.PresetMetaLinter).
 			ConsiderSlow().