Skip to content

Fix removeEmptyPort #76652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxasu wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −4
Open

Fix removeEmptyPort #76652

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
770502a
Fix removeEmptyPort
dxasu Dec 2, 2025
2eb154b
Simplify removeEmptyPort function implementation
dxasu Dec 2, 2025
647cf55
Simplify removeEmptyPort function implementation
dxasu Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/net/http/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ func hasPort(s string) bool { return strings.LastIndex(s, ":") > strings.LastInd
// removeEmptyPort strips the empty port in ":port" to ""
// as mandated by RFC 3986 Section 6.2.3.
func removeEmptyPort(host string) string {
if hasPort(host) {
return strings.TrimSuffix(host, ":")
}
return host
return strings.TrimSuffix(host, ":")
}

// isToken reports whether v is a valid token (https://www.rfc-editor.org/rfc/rfc2616#section-2.2).
Expand Down