Skip to content

Commit de45645

Browse files
DanielMorsinggopherbot
authored andcommitted
runtime/secret: disable tests under memory validating modes
These tests rely on reading memory that has been freed, so any of the modes that validate memory accesses are going to fail. Disable them for now. Fixes #76586. Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-msan-clang15,gotip-linux-amd64-asan-clang15,gotip-linux-amd64-race Change-Id: I14ee5dfccbafa0e4da684a95ee42acf54499b013 Reviewed-on: https://go-review.googlesource.com/c/go/+/725140 Auto-Submit: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
1 parent 67d4a28 commit de45645

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/runtime/secret/secret_test.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
// the race detector does not like our pointer shenanigans
6-
// while checking the stack.
7-
8-
//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race
5+
// these tests rely on inspecting freed memory, so they
6+
// can't be run under any of the memory validating modes.
7+
// TODO: figure out just which test violate which condition
8+
// and split this file out by individual test cases.
9+
// There could be some value to running some of these
10+
// under validation
11+
12+
//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race && !asan && !msan
913

1014
package secret
1115

0 commit comments

Comments
 (0)