Feat: MapClaims Key Type-Safety #485
Open
+23
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That is a very interesting idea. I wonder how backwards-compatible this is, since we do not want to break existing code in the v5 branch and it does modify public API functions. Need to play around with that first. In any case this could be interesting for a v6, for which I want to start the development soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this feature to improve type safety, preventing us from mistyping the string in MapClaims, thus providing a slightly better experience. Of course, with 5 minutes of research you already know what MapClaims expects, but with this safety feature, simply pressing ctrl+space shows developers the types it expects.
Before
After
I can blend the new way with the old way and it works.
ctrl+space