Merge pull request #1711 from BenLubar/vector-bsearch-const

dsnopek · web-flow · commit 2d7941d0dc96 · 2025-11-27T05:15:41.000-06:00
Make Vector&lt;T&gt;::bsearch use a const receiver
diff --git a/include/godot_cpp/templates/vector.hpp b/include/godot_cpp/templates/vector.hpp
@@ -124,14 +124,14 @@ class Vector {
 		sorter.sort(data, len);
 	}
 
-	Size bsearch(const T &p_value, bool p_before) {
+	Size bsearch(const T &p_value, bool p_before) const {
 		return bsearch_custom<_DefaultComparator<T>>(p_value, p_before);
 	}
 
 	template <typename Comparator, typename Value, typename... Args>
-	Size bsearch_custom(const Value &p_value, bool p_before, Args &&...args) {
+	Size bsearch_custom(const Value &p_value, bool p_before, Args &&...args) const {
 		SearchArray<T, Comparator> search{ args... };
-		return search.bisect(ptrw(), size(), p_value, p_before);
+		return search.bisect(ptr(), size(), p_value, p_before);
 	}
 
 	Vector<T> duplicate() {

Original file line number	Diff line number	Diff line change
`@@ -124,14 +124,14 @@ class Vector {`
`124`	`124`	`sorter.sort(data, len);`
`125`	`125`	`}`
`126`	`126`
`127`		`- Size bsearch(const T &p_value, bool p_before) {`
	`127`	`+ Size bsearch(const T &p_value, bool p_before) const {`
`128`	`128`	`return bsearch_custom<_DefaultComparator<T>>(p_value, p_before);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`template <typename Comparator, typename Value, typename... Args>`
`132`		`- Size bsearch_custom(const Value &p_value, bool p_before, Args &&...args) {`
	`132`	`+ Size bsearch_custom(const Value &p_value, bool p_before, Args &&...args) const {`
`133`	`133`	`SearchArray<T, Comparator> search{ args... };`
`134`		`- return search.bisect(ptrw(), size(), p_value, p_before);`
	`134`	`+ return search.bisect(ptr(), size(), p_value, p_before);`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`Vector<T> duplicate() {`