Skip to content

Commit 40611e5

Browse files
committed
fix(test): Replace undefined functions in project API tests
- Replace ExistsProjectByID with GetProjectByID + IsErrProjectNotExist - Replace ExistsColumnByID with GetColumn + IsErrProjectColumnNotExist - Replace GetProjectIssue with unittest.AssertExistsAndLoadBean These functions were not defined in the models/project package, causing CI lint and test failures.
1 parent 5784513 commit 40611e5

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

tests/integration/api_repo_project_test.go

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,8 @@ func TestAPIDeleteProject(t *testing.T) {
243243
MakeRequest(t, req, http.StatusNoContent)
244244

245245
// Verify project is deleted
246-
exists, err := project_model.ExistsProjectByID(t.Context(), project.ID)
247-
assert.NoError(t, err)
248-
assert.False(t, exists)
246+
_, err = project_model.GetProjectByID(db.DefaultContext, project.ID)
247+
assert.True(t, project_model.IsErrProjectNotExist(err))
249248

250249
// Test deleting non-existent project
251250
req = NewRequestf(t, "DELETE", "/api/v1/repos/%s/%s/projects/99999", owner.Name, repo.Name).
@@ -463,9 +462,8 @@ func TestAPIDeleteProjectColumn(t *testing.T) {
463462
MakeRequest(t, req, http.StatusNoContent)
464463

465464
// Verify column is deleted
466-
exists, err := project_model.ExistsColumnByID(t.Context(), column.ID)
467-
assert.NoError(t, err)
468-
assert.False(t, exists)
465+
_, err = project_model.GetColumn(db.DefaultContext, column.ID)
466+
assert.True(t, project_model.IsErrProjectColumnNotExist(err))
469467

470468
// Test deleting non-existent column
471469
req = NewRequestf(t, "DELETE", "/api/v1/repos/%s/%s/projects/columns/99999", owner.Name, repo.Name).
@@ -519,9 +517,7 @@ func TestAPIAddIssueToProjectColumn(t *testing.T) {
519517
MakeRequest(t, req, http.StatusCreated)
520518

521519
// Verify issue is in the column
522-
projectIssue, err := project_model.GetProjectIssue(t.Context(), issue.ID)
523-
assert.NoError(t, err)
524-
assert.NotNil(t, projectIssue)
520+
projectIssue := unittest.AssertExistsAndLoadBean(t, &project_model.ProjectIssue{IssueID: issue.ID})
525521
assert.Equal(t, column1.ID, projectIssue.ProjectColumnID)
526522

527523
// Test moving issue to another column
@@ -531,8 +527,7 @@ func TestAPIAddIssueToProjectColumn(t *testing.T) {
531527
MakeRequest(t, req, http.StatusCreated)
532528

533529
// Verify issue moved to new column
534-
projectIssue, err = project_model.GetProjectIssue(t.Context(), issue.ID)
535-
assert.NoError(t, err)
530+
projectIssue = unittest.AssertExistsAndLoadBean(t, &project_model.ProjectIssue{IssueID: issue.ID})
536531
assert.Equal(t, column2.ID, projectIssue.ProjectColumnID)
537532

538533
// Test adding same issue to same column (should be idempotent)

0 commit comments

Comments
 (0)