-
Notifications
You must be signed in to change notification settings - Fork 18
Description
"trending", "new", "popular", and "updated" should be reserved names, and should be rejected when provided as plugin key in the XML file of any plugin.
This is because, the fact of having those reserved names could lead to some conflicts, like :
/api/plugin/room => card of a single plugin
/api/plugin/trending => list of all trending plugins
/api/plugin/new => list of all recently added plugins
/api/plugin/popular => list of all popular plugins
/api/plugin/updated => list of all recently updated plugins
but what if we have new as a plugin key,
the url for the plugin at the API level would be : /api/plugin/new
which is in conflict with the endpoint that lists all the recently added plugins.
In fact, this conflicts is not that much of a problem for the Slim Framework's Router,
because the "list of new plugins" endpoint is registered on the router before the
"single plugin" endpoint, so this, won't break the homepage;
but the plugin will still be unavailable for direct query of it's card.