add clippy::nursery checks

Author: Stephan Dilly

src/app.rs

@@ -64,9 +64,9 @@ impl App {
             help: HelpComponent::new(&theme),
             msg: MsgComponent::new(&theme),
             tab: 0,
-            revlog: Revlog::new(&sender, &theme),
-            status_tab: Status::new(&sender, &queue, &theme),
-            stashing_tab: Stashing::new(&sender, &queue, &theme),
+            revlog: Revlog::new(sender, &theme),
+            status_tab: Status::new(sender, &queue, &theme),
+            stashing_tab: Stashing::new(sender, &queue, &theme),
             stashlist_tab: StashList::new(&queue, &theme),
             queue,
             theme,
@@ -191,7 +191,7 @@ impl App {
     }
 
     ///
-    pub fn is_quit(&self) -> bool {
+    pub const fn is_quit(&self) -> bool {
         self.do_quit
     }
 

src/components/command.rs

@@ -50,7 +50,7 @@ pub struct CommandInfo {
 
 impl CommandInfo {
     ///
-    pub fn new(
+    pub const fn new(
         text: CommandText,
         enabled: bool,
         available: bool,
@@ -64,13 +64,13 @@ impl CommandInfo {
         }
     }
     ///
-    pub fn order(self, order: i8) -> Self {
+    pub const fn order(self, order: i8) -> Self {
         let mut res = self;
         res.order = order;
         res
     }
     ///
-    pub fn hidden(self) -> Self {
+    pub const fn hidden(self) -> Self {
         let mut res = self;
         res.quick_bar = false;
         res

src/components/commitlist.rs

@@ -58,12 +58,12 @@ impl CommitList {
     }
 
     ///
-    pub fn selection(&self) -> usize {
+    pub const fn selection(&self) -> usize {
         self.selection
     }
 
     ///
-    pub fn current_size(&self) -> (u16, u16) {
+    pub const fn current_size(&self) -> (u16, u16) {
         self.current_size
     }
 
@@ -73,12 +73,13 @@ impl CommitList {
     }
 
     ///
+    #[allow(clippy::missing_const_for_fn)]
     pub fn selection_max(&self) -> usize {
         self.count_total.saturating_sub(1)
     }
 
     ///
-    pub fn tags(&self) -> &Tags {
+    pub const fn tags(&self) -> &Tags {
         &self.tags
     }
 
@@ -242,6 +243,7 @@ impl CommitList {
         txt
     }
 
+    #[allow(clippy::missing_const_for_fn)]
     fn relative_selection(&self) -> usize {
         self.selection.saturating_sub(self.items.index_offset())
     }

src/components/diff.rs

@@ -54,7 +54,7 @@ impl DiffComponent {
         }
     }
     ///
-    fn can_scroll(&self) -> bool {
+    const fn can_scroll(&self) -> bool {
         self.diff.lines > 1
     }
     ///

src/components/msg.rs

@@ -96,7 +96,7 @@ impl Component for MsgComponent {
 }
 
 impl MsgComponent {
-    pub fn new(theme: &Theme) -> Self {
+    pub const fn new(theme: &Theme) -> Self {
         Self {
             msg: String::new(),
             visible: false,

src/components/textinput.rs

@@ -48,7 +48,7 @@ impl TextInputComponent {
     }
 
     ///
-    pub fn get_text(&self) -> &String {
+    pub const fn get_text(&self) -> &String {
         &self.msg
     }
 }

src/components/utils/filetree.rs

@@ -23,7 +23,11 @@ pub struct TreeItemInfo {
 }
 
 impl TreeItemInfo {
-    fn new(indent: u8, path: String, full_path: String) -> Self {
+    const fn new(
+        indent: u8,
+        path: String,
+        full_path: String,
+    ) -> Self {
         Self {
             indent,
             visible: true,
@@ -147,22 +151,22 @@ impl FileTreeItems {
             {
                 let item_path = Path::new(&e.path);
 
-                FileTreeItems::push_dirs(
+                Self::push_dirs(
                     item_path,
                     &mut nodes,
                     &mut paths_added,
-                    &collapsed,
+                    collapsed,
                 )?;
             }
 
-            nodes.push(FileTreeItem::new_file(&e)?);
+            nodes.push(FileTreeItem::new_file(e)?);
         }
 
         Ok(Self(nodes))
     }
 
     ///
-    pub(crate) fn items(&self) -> &Vec<FileTreeItem> {
+    pub(crate) const fn items(&self) -> &Vec<FileTreeItem> {
         &self.0
     }
 

src/components/utils/logitems.rs

@@ -45,7 +45,7 @@ impl ItemBatch {
     }
 
     ///
-    pub fn index_offset(&self) -> usize {
+    pub const fn index_offset(&self) -> usize {
         self.index_offset
     }
 

src/components/utils/statustree.rs

@@ -29,7 +29,7 @@ struct SelectionChange {
     changes: bool,
 }
 impl SelectionChange {
-    fn new(new_index: usize, changes: bool) -> Self {
+    const fn new(new_index: usize, changes: bool) -> Self {
         Self { new_index, changes }
     }
 }

src/main.rs

@@ -4,6 +4,7 @@
 //https://github.com/crossterm-rs/crossterm/issues/432
 #![allow(clippy::cargo::multiple_crate_versions)]
 #![deny(clippy::pedantic)]
+#![deny(clippy::nursery)]
 #![deny(clippy::result_unwrap_used)]
 #![deny(clippy::panic)]
 #![allow(clippy::module_name_repetitions)]