clippy fixes

Author: Stephan Dilly

asyncgit/src/sync/diff.rs

@@ -173,7 +173,7 @@ pub fn get_diff(repo_path: &str, p: String, stage: bool) -> FileDiff {
                 repo_path.join(delta.new_file().path().unwrap());
 
             let newfile_content = new_file_content(&newfile_path)
-                .unwrap_or(String::from("file not found"));
+                .unwrap_or_else(|| String::from("file not found"));
 
             let mut patch = Patch::from_buffers(
                 &[],

src/components/changes.rs

@@ -166,7 +166,7 @@ impl ChangesComponent {
         match &item.kind {
             FileTreeItemKind::File(status_item) => {
                 let status_char =
-                    Self::item_status_char(&status_item.status);
+                    Self::item_status_char(status_item.status);
                 let file = Path::new(&status_item.path)
                     .file_name()
                     .unwrap()
@@ -182,7 +182,7 @@ impl ChangesComponent {
                         w = width as usize
                     )
                 } else {
-                    format!("{} {}{}", status_char, indent_str, file) //M + - R
+                    format!("{} {}{}", status_char, indent_str, file)
                 };
 
                 let mut style =
@@ -239,7 +239,7 @@ impl ChangesComponent {
         }
     }
 
-    fn item_status_char(item_type: &Option<StatusItemType>) -> char {
+    fn item_status_char(item_type: Option<StatusItemType>) -> char {
         if let Some(item_type) = item_type {
             match item_type {
                 StatusItemType::Modified => 'M',