Secondary sidebar visible by default in new workspace (fix microsoft#259496) (microsoft#261998)

Author: bpasero

src/vs/workbench/browser/layout.ts

@@ -2846,16 +2846,16 @@ class LayoutStateModel extends Disposable {
 		LayoutStateKeys.SIDEBAR_HIDDEN.defaultValue = workbenchState === WorkbenchState.EMPTY;
 		LayoutStateKeys.AUXILIARYBAR_SIZE.defaultValue = Math.min(300, mainContainerDimension.width / 4);
 		LayoutStateKeys.AUXILIARYBAR_HIDDEN.defaultValue = (() => {
-
-			// TODO@bpasero: lots of hacks here to not force open the auxiliary sidebar
-			// when no Chat view is present within:
-			// - revisit this when/if the default value of workbench.secondarySideBar.defaultVisibility changes
-			// - revisit this when Chat is available in serverless web
-			// - drop the need to probe for chat.setupContext
-			// - drop the need to probe for chat.hideAIFeatures
-			// - drop the need to probe for view location of workbench.panel.chat.view.copilot
 			const configuration = this.configurationService.inspect(WorkbenchLayoutSettings.AUXILIARYBAR_DEFAULT_VISIBILITY);
 			if (configuration.defaultValue !== 'hidden' && !isConfigured(configuration)) {
+
+				// TODO@bpasero: lots of hacks here to not force open the auxiliary sidebar
+				// when no Chat view is present within:
+				// - revisit this when Chat is available in serverless web
+				// - drop the need to probe for chat.setupContext
+				// - drop the need to probe for chat.hideAIFeatures
+				// - drop the need to probe for view location of workbench.panel.chat.view.copilot
+
 				if (isWeb && !this.environmentService.remoteAuthority) {
 					return true; // Chat view is not enabled
 				}
@@ -2872,20 +2872,23 @@ class LayoutStateModel extends Disposable {
 			}
 
 			// New users: Show auxiliary bar even in empty workspaces
-			if (this.storageService.isNew(StorageScope.APPLICATION)) {
+			// but not if the user explicitly hides it
+			if (
+				this.storageService.isNew(StorageScope.APPLICATION) &&
+				configuration.value !== 'hidden'
+			) {
 				return false;
 			}
 
 			// Existing users: respect visibility setting
-			switch (this.configurationService.getValue(WorkbenchLayoutSettings.AUXILIARYBAR_DEFAULT_VISIBILITY)) {
-				case 'maximized':
-				case 'visible':
-					return false;
+			switch (configuration.value) {
+				case 'hidden':
+					return true;
 				case 'visibleInWorkspace':
 				case 'maximizedInWorkspace':
 					return workbenchState === WorkbenchState.EMPTY;
 				default:
-					return true;
+					return false;
 			}
 		})();
 		LayoutStateKeys.PANEL_SIZE.defaultValue = (this.stateCache.get(LayoutStateKeys.PANEL_POSITION.name) ?? isHorizontal(LayoutStateKeys.PANEL_POSITION.defaultValue)) ? mainContainerDimension.height / 3 : mainContainerDimension.width / 4;

src/vs/workbench/browser/workbench.contribution.ts

@@ -552,10 +552,7 @@ const registry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Con
 			'workbench.secondarySideBar.defaultVisibility': {
 				'type': 'string',
 				'enum': ['hidden', 'visibleInWorkspace', 'visible', 'maximizedInWorkspace', 'maximized'],
-				'default': 'hidden',
-				'experiment': {
-					mode: 'startup'
-				},
+				'default': 'visibleInWorkspace',
 				'description': localize('secondarySideBarDefaultVisibility', "Controls the default visibility of the secondary side bar in workspaces or empty windows opened for the first time."),
 				'enumDescriptions': [
 					localize('workbench.secondarySideBar.defaultVisibility.hidden', "The secondary side bar is hidden by default."),