Show no results pick when we have no input (microsoft#175576)

TylerLeonhardt · web-flow · commit ebc6d675b781 · 2023-02-28T06:13:38.000+01:00
Fixes microsoft#172613
diff --git a/src/vs/platform/quickinput/browser/pickerQuickAccess.ts b/src/vs/platform/quickinput/browser/pickerQuickAccess.ts
@@ -139,7 +139,8 @@ export abstract class PickerQuickAccessProvider<T extends IPickerQuickAccessItem
 						return false;
 					}
 
-					if (picksFilter.length > 0 && this.options?.noResultsPick) {
+					// We show the no results pick if we have no input to prevent completely empty pickers #172613
+					if ((picksFilter.length > 0 || picker.hideInput) && this.options?.noResultsPick) {
 						items = [this.options.noResultsPick];
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,8 @@ export abstract class PickerQuickAccessProvider<T extends IPickerQuickAccessItem`
`139`	`139`	`return false;`
`140`	`140`	`}`
`141`	`141`
`142`		`- if (picksFilter.length > 0 && this.options?.noResultsPick) {`
	`142`	`+ // We show the no results pick if we have no input to prevent completely empty pickers #172613`
	`143`	`+ if ((picksFilter.length > 0 \|\| picker.hideInput) && this.options?.noResultsPick) {`
`143`	`144`	`items = [this.options.noResultsPick];`
`144`	`145`	`}`
`145`	`146`	`}`