Miscellaneous NL Command Palette improvements (microsoft#185382)

* Always show "Ask Copilot"
* Open Quick Question UX instead of Chat view
* If we have _any_ similar commands, show the "similar commands" separators even if there are no regular picks
* Have Semantic Similarity setting be on by default
* Remove QQ setting since it's not really useful

Author: TylerLeonhardt

src/vs/platform/quickinput/browser/commandsQuickAccess.ts

@@ -26,6 +26,7 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 export interface ICommandQuickPick extends IPickerQuickAccessItem {
 	readonly commandId: string;
 	readonly commandAlias?: string;
+	readonly args?: any[];
 }
 
 export interface ICommandsQuickAccessOptions extends IPickerQuickAccessProviderOptions<ICommandQuickPick> {
@@ -211,7 +212,9 @@ export abstract class AbstractCommandsQuickAccessProvider extends PickerQuickAcc
 
 				// Run
 				try {
-					await this.commandService.executeCommand(commandPick.commandId);
+					commandPick.args?.length
+						? await this.commandService.executeCommand(commandPick.commandId, ...commandPick.args)
+						: await this.commandService.executeCommand(commandPick.commandId);
 				} catch (error) {
 					if (!isCancellationError(error)) {
 						this.dialogService.error(localize('canNotRun', "Command '{0}' resulted in an error", commandPick.label), toErrorMessage(error));

src/vs/workbench/browser/workbench.contribution.ts

@@ -358,7 +358,7 @@ const registry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Con
 				'type': 'boolean',
 				tags: ['experimental'],
 				'description': localize('useSemanticSimilarity', "Controls whether the command palette should include similar commands. You must have an extension installed that provides Semantic Similarity."),
-				'default': false
+				'default': true
 			},
 			'workbench.quickOpen.closeOnFocusLost': {
 				'type': 'boolean',

src/vs/workbench/contrib/chat/browser/actions/chatQuickInputActions.ts

@@ -24,9 +24,10 @@ import { IChatReplyFollowup, IChatService } from 'vs/workbench/contrib/chat/comm
 import { ChatViewModel } from 'vs/workbench/contrib/chat/common/chatViewModel';
 import { CHAT_CATEGORY } from 'vs/workbench/contrib/chat/browser/actions/chatActions';
 import { IChatWidgetService } from 'vs/workbench/contrib/chat/browser/chat';
-import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
 import { CONTEXT_PROVIDER_EXISTS } from 'vs/workbench/contrib/chat/common/chatContextKeys';
 
+export const ASK_QUICK_QUESTION_ACTION_ID = 'chat.action.askQuickQuestion';
+
 export function registerChatQuickQuestionActions() {
 	registerAction2(AskQuickQuestionAction);
 }
@@ -41,15 +42,14 @@ class AskQuickQuestionAction extends Action2 {
 
 	constructor() {
 		super({
-			id: 'chat.action.askQuickQuestion',
+			id: ASK_QUICK_QUESTION_ACTION_ID,
 			title: { value: localize('askQuickQuestion', "Ask Quick Question"), original: 'Ask Quick Question' },
 			precondition: CONTEXT_PROVIDER_EXISTS,
-			f1: true,
+			f1: false,
 			category: CHAT_CATEGORY,
 			keybinding: {
 				weight: KeybindingWeight.WorkbenchContrib,
-				primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KeyI,
-				when: ContextKeyExpr.equals('config.chat.experimental.quickQuestion.enable', true),
+				primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KeyI
 			}
 		});
 	}

src/vs/workbench/contrib/chat/browser/chat.contribution.ts

@@ -70,12 +70,6 @@ configurationRegistry.registerConfiguration({
 			type: 'number',
 			description: nls.localize('interactiveSession.editor.lineHeight', "Controls the line height in pixels in chat codeblocks. Use 0 to compute the line height from the font size."),
 			default: 0
-		},
-		'chat.experimental.quickQuestion.enable': {
-			type: 'boolean',
-			description: nls.localize('interactiveSession.experimental.quickQuestion.enable', "Controls whether the quick question feature is enabled."),
-			default: false,
-			tags: ['experimental']
 		}
 	}
 });

src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts

@@ -35,8 +35,7 @@ import { isFirefox } from 'vs/base/browser/browser';
 import { IProductService } from 'vs/platform/product/common/productService';
 import { ISemanticSimilarityService } from 'vs/workbench/services/semanticSimilarity/common/semanticSimilarityService';
 import { IChatService } from 'vs/workbench/contrib/chat/common/chatService';
-import { ILogService } from 'vs/platform/log/common/log';
-import { IChatWidgetService } from 'vs/workbench/contrib/chat/browser/chat';
+import { ASK_QUICK_QUESTION_ACTION_ID } from 'vs/workbench/contrib/chat/browser/actions/chatQuickInputActions';
 
 export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAccessProvider {
 
@@ -80,19 +79,10 @@ export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAcce
 	) {
 		super({
 			showAlias: !Language.isDefaultVariant(),
-			noResultsPick: (filter) => {
-				const info = this.chatService.getProviderInfos()[0];
-				return info
-					? {
-						label: localize('askXInChat', "Ask {0}: {1}", info.displayName, filter),
-						commandId: AskInInteractiveAction.ID,
-						accept: () => commandService.executeCommand(AskInInteractiveAction.ID, filter)
-					}
-					: {
-						label: localize('noCommandResults', "No matching commands"),
-						commandId: ''
-					};
-			},
+			noResultsPick: () => ({
+				label: localize('noCommandResults', "No matching commands"),
+				commandId: ''
+			}),
 		}, instantiationService, keybindingService, commandService, telemetryService, dialogService);
 
 		this._register(configurationService.onDidChangeConfiguration((e) => this.updateOptions(e)));
@@ -175,12 +165,7 @@ export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAcce
 
 		const sortedIndices = scores.map((_, i) => i).sort((a, b) => scores[b] - scores[a]);
 		const setOfPicksSoFar = new Set(picksSoFar.map(p => p.commandId));
-		const additionalPicks: Array<ICommandQuickPick | IQuickPickSeparator> = picksSoFar.length > 0
-			? [{
-				type: 'separator',
-				label: localize('semanticSimilarity', "similar commands")
-			}]
-			: [];
+		const additionalPicks = new Array<ICommandQuickPick | IQuickPickSeparator>();
 
 		let numOfSmartPicks = 0;
 		for (const i of sortedIndices) {
@@ -196,6 +181,28 @@ export class CommandsQuickAccessProvider extends AbstractEditorCommandsQuickAcce
 			}
 		}
 
+		if (numOfSmartPicks) {
+			additionalPicks.unshift({
+				type: 'separator',
+				label: localize('semanticSimilarity', "similar commands")
+			});
+		}
+
+		if (picksSoFar.length || additionalPicks.length) {
+			additionalPicks.push({
+				type: 'separator'
+			});
+		}
+
+		const info = this.chatService.getProviderInfos()[0];
+		if (info) {
+			additionalPicks.push({
+				label: localize('askXInChat', "Ask {0}: {1}", info.displayName, filter),
+				commandId: ASK_QUICK_QUESTION_ACTION_ID,
+				args: [filter]
+			});
+		}
+
 		return additionalPicks;
 	}
 
@@ -299,48 +306,4 @@ export class ClearCommandHistoryAction extends Action2 {
 	}
 }
 
-// TODO: Should this live here? It seems fairly generic and could live in the interactive code.
-export class AskInInteractiveAction extends Action2 {
-
-	static readonly ID = 'workbench.action.askCommandInChat';
-
-	constructor() {
-		super({
-			id: AskInInteractiveAction.ID,
-			title: { value: localize('askInChat', "Ask In Chat"), original: 'Ask In Chat' },
-			f1: false
-		});
-	}
-
-	async run(accessor: ServicesAccessor, filter?: string): Promise<void> {
-		const chatService = accessor.get(IChatService);
-		const chatWidgetService = accessor.get(IChatWidgetService);
-		const logService = accessor.get(ILogService);
-
-		if (!filter) {
-			throw new Error('No filter provided.');
-		}
-
-		let providerId: string;
-		const providerInfos = chatService.getProviderInfos();
-		switch (providerInfos.length) {
-			case 0:
-				throw new Error('No chat provider found.');
-			case 1:
-				providerId = providerInfos[0].id;
-				break;
-			default:
-				logService.warn('Multiple chat providers found. Using the first one.');
-				providerId = providerInfos[0].id;
-				break;
-		}
-
-		const widget = await chatWidgetService.revealViewForProvider(providerId);
-		if (widget?.viewModel) {
-			// TODO: Maybe this could provide metadata saying it came from the command palette?
-			chatService.sendRequestToProvider(widget.viewModel.sessionId, { message: filter });
-		}
-	}
-}
-
 //#endregion

src/vs/workbench/contrib/quickaccess/browser/quickAccess.contribution.ts

@@ -8,7 +8,7 @@ import { IQuickAccessRegistry, Extensions } from 'vs/platform/quickinput/common/
 import { Registry } from 'vs/platform/registry/common/platform';
 import { HelpQuickAccessProvider } from 'vs/platform/quickinput/browser/helpQuickAccess';
 import { ViewQuickAccessProvider, OpenViewPickerAction, QuickAccessViewPickerAction } from 'vs/workbench/contrib/quickaccess/browser/viewQuickAccess';
-import { CommandsQuickAccessProvider, ShowAllCommandsAction, ClearCommandHistoryAction, AskInInteractiveAction } from 'vs/workbench/contrib/quickaccess/browser/commandsQuickAccess';
+import { CommandsQuickAccessProvider, ShowAllCommandsAction, ClearCommandHistoryAction } from 'vs/workbench/contrib/quickaccess/browser/commandsQuickAccess';
 import { MenuRegistry, MenuId, registerAction2 } from 'vs/platform/actions/common/actions';
 import { KeyMod } from 'vs/base/common/keyCodes';
 import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
@@ -112,7 +112,6 @@ registerAction2(ClearCommandHistoryAction);
 registerAction2(ShowAllCommandsAction);
 registerAction2(OpenViewPickerAction);
 registerAction2(QuickAccessViewPickerAction);
-registerAction2(AskInInteractiveAction);
 
 const inViewsPickerContextKey = 'inViewsPicker';
 const inViewsPickerContext = ContextKeyExpr.and(inQuickPickContext, ContextKeyExpr.has(inViewsPickerContextKey));