variables: don't keep an lru for pw inputs (microsoft#262206)

connor4312 · web-flow · commit 669d9b506d2f · 2025-08-18T21:36:01.000Z
diff --git a/src/vs/workbench/services/configurationResolver/browser/baseConfigurationResolverService.ts b/src/vs/workbench/services/configurationResolver/browser/baseConfigurationResolverService.ts
@@ -274,7 +274,7 @@ export abstract class BaseConfigurationResolverService extends AbstractVariableR
 						inputOptions.password = info.password;
 					}
 					return this.userInputAccessQueue.queue(() => this.quickInputService.input(inputOptions)).then(resolvedInput => {
-						if (typeof resolvedInput === 'string') {
+						if (typeof resolvedInput === 'string' && !info.password) {
 							this.storeInputLru(defaultValueMap.set(defaultValueKey, resolvedInput));
 						}
 						return resolvedInput !== undefined ? { value: resolvedInput as string, input: info } : undefined;

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ export abstract class BaseConfigurationResolverService extends AbstractVariableR`
`274`	`274`	`inputOptions.password = info.password;`
`275`	`275`	`}`
`276`	`276`	`return this.userInputAccessQueue.queue(() => this.quickInputService.input(inputOptions)).then(resolvedInput => {`
`277`		`- if (typeof resolvedInput === 'string') {`
	`277`	`+ if (typeof resolvedInput === 'string' && !info.password) {`
`278`	`278`	`this.storeInputLru(defaultValueMap.set(defaultValueKey, resolvedInput));`
`279`	`279`	`}`
`280`	`280`	`return resolvedInput !== undefined ? { value: resolvedInput as string, input: info } : undefined;`