Skip to content

Commit 5d14baf

Browse files
authored
Add opportunityId to inlineCompletion.endOfLife (microsoft#261543)
1 parent b824060 commit 5d14baf

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,7 @@ export class MainThreadLanguageFeatures extends Disposable implements MainThread
651651
}
652652
const endOfLifeSummary: InlineCompletionEndOfLifeEvent = {
653653
id: lifetimeSummary.requestUuid,
654+
opportunityId: lifetimeSummary.requestUuid,
654655
shown: lifetimeSummary.shown,
655656
shownDuration: lifetimeSummary.shownDuration,
656657
shownDurationUncollapsed: lifetimeSummary.shownDurationUncollapsed,
@@ -1309,7 +1310,11 @@ export class MainThreadDocumentRangeSemanticTokensProvider implements languages.
13091310
}
13101311

13111312
type InlineCompletionEndOfLifeEvent = {
1313+
/**
1314+
* @deprecated To be removed at one point in favor of opportunityId
1315+
*/
13121316
id: string;
1317+
opportunityId: string;
13131318
extensionId: string;
13141319
extensionVersion: string;
13151320
shown: boolean;
@@ -1346,6 +1351,7 @@ type InlineCompletionsEndOfLifeClassification = {
13461351
owner: 'benibenj';
13471352
comment: 'Inline completions ended';
13481353
id: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The identifier for the inline completion request' };
1354+
opportunityId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Unique identifier for an opportunity to show an inline completion or NES' };
13491355
extensionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The identifier for the extension that contributed the inline completion' };
13501356
extensionVersion: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The version of the extension that contributed the inline completion' };
13511357
shown: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the inline completion was shown to the user' };

0 commit comments

Comments
 (0)