Report GOAWAY error

Author: jeanp413

src/extension.ts

@@ -78,7 +78,7 @@ export async function activate(context: vscode.ExtensionContext) {
 		const hostService = new HostService(context, notificationService, logger);
 		context.subscriptions.push(hostService);
 
-		const sessionService = new SessionService(hostService, logger);
+		const sessionService = new SessionService(hostService, logger, telemetryService);
 		context.subscriptions.push(sessionService);
 
 		const remoteService = new RemoteService(context, hostService, telemetryService, sessionService, logger);

src/publicApi.ts

@@ -16,6 +16,7 @@ import { timeout } from './common/async';
 import { MetricsReporter, getConnectMetricsInterceptor } from './metrics';
 import { ILogService } from './services/logService';
 import { WrapError } from './common/utils';
+import { ITelemetryService } from './common/telemetry';
 
 function isTelemetryEnabled(): boolean {
     const TELEMETRY_CONFIG_ID = 'telemetry';
@@ -52,7 +53,12 @@ export class GitpodPublicApi extends Disposable implements IGitpodAPI {
 
     private workspaceStatusStreamMap = new Map<string, { onStatusChanged: vscode.Event<WorkspaceStatus>; dispose: (force?: boolean) => void; increment: () => void }>();
 
-    constructor(private accessToken: string, private gitpodHost: string, private logger: ILogService) {
+    constructor(
+        private readonly accessToken: string,
+        private readonly gitpodHost: string,
+        private readonly logger: ILogService,
+        private readonly telemetryService: ITelemetryService
+    ) {
         super();
 
         this.createClients();
@@ -201,6 +207,7 @@ export class GitpodPublicApi extends Disposable implements IGitpodAPI {
             // Remove this once it's fixed upstream
             const message: string = e.stack || e.message || `${e}`;
             if (message.includes('New streams cannot be created after receiving a GOAWAY')) {
+                this.telemetryService.sendTelemetryException(e);
                 this.logger.error('Got GOAWAY bug, recreating connect client');
                 this.createClients();
             }
@@ -236,6 +243,7 @@ export class GitpodPublicApi extends Disposable implements IGitpodAPI {
                 // Remove this once it's fixed upstream
                 const message: string = e.stack || e.message || `${e}`;
                 if (message.includes('New streams cannot be created after receiving a GOAWAY')) {
+                    this.telemetryService.sendTelemetryException(e);
                     this.logger.error('Got GOAWAY bug, recreating connect client');
                     this.createClients();
 

src/services/sessionService.ts

@@ -9,6 +9,7 @@ import { IHostService } from './hostService';
 import { GitpodPublicApi, IGitpodAPI } from '../publicApi';
 import { eventToPromise } from '../common/event';
 import { ILogService } from './logService';
+import { ITelemetryService } from '../common/telemetry';
 
 export class NoSignedInError extends Error {
     constructor() {
@@ -56,7 +57,8 @@ export class SessionService extends Disposable implements ISessionService {
 
     constructor(
         private readonly hostService: IHostService,
-        private readonly logger: ILogService
+        private readonly logger: ILogService,
+        private readonly telemetryService: ITelemetryService
     ) {
         super();
 
@@ -168,7 +170,7 @@ export class SessionService extends Disposable implements ISessionService {
             throw new NoSignedInError();
         }
         if (!this._publicApi) {
-            this._publicApi = new GitpodPublicApi(this.getGitpodToken(), this.hostService.gitpodHost, this.logger);
+            this._publicApi = new GitpodPublicApi(this.getGitpodToken(), this.hostService.gitpodHost, this.logger, this.telemetryService);
         }
         return this._publicApi;
     }