Skip to content

Commit ae6e510

Browse files
committed
Refines cards layout
(#4769, #4773, PLG-138)
1 parent 816c412 commit ae6e510

File tree

3 files changed

+15
-24
lines changed

3 files changed

+15
-24
lines changed

src/webviews/apps/welcome/components/feature-carousel.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ export class GlFeatureCarousel extends LitElement {
1414
static override styles = [
1515
css`
1616
:host {
17-
--gl-carousel-border-radius: 0;
18-
--gl-carousel-background-color: transparent;
19-
--gl-carousel-padding: 1em;
20-
2117
display: block;
2218
width: 100%;
2319
}
@@ -39,10 +35,6 @@ export class GlFeatureCarousel extends LitElement {
3935
display: flex;
4036
align-items: center;
4137
justify-content: center;
42-
43-
border-radius: var(--gl-carousel-border-radius);
44-
background-color: var(--gl-carousel-background-color);
45-
padding: var(--gl-carousel-padding);
4638
}
4739
4840
::slotted(*) {

src/webviews/apps/welcome/welcome.css.ts

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -141,44 +141,43 @@ const header = css`
141141
}
142142
`;
143143

144-
const carousel = css`
145-
gl-feature-carousel {
144+
const cards = css`
145+
.card {
146+
border-radius: 0.63em;
147+
background-color: var(--vscode-textBlockQuote-background);
148+
padding: 1.8em;
146149
text-align: initial;
147-
--gl-carousel-border-radius: 0.63em;
148-
--gl-carousel-padding: 1.8em;
149-
--gl-carousel-background-color: var(--vscode-textBlockQuote-background);
150150
}
151151
152152
@media (max-width: 640px) {
153-
gl-feature-carousel {
154-
--gl-carousel-padding: 1em;
153+
.card {
154+
padding: 1em;
155155
}
156156
}
157157
158158
@media (max-width: 300px) {
159-
gl-feature-carousel {
160-
--gl-carousel-padding: 0.5em;
159+
.card {
160+
padding: 0.5em;
161161
}
162162
}
163163
164-
gl-feature-carousel h1 {
164+
.card h1 {
165165
margin: 0;
166166
font-size: var(--card-font-size);
167167
}
168168
169-
gl-feature-carousel p {
169+
.card p {
170170
margin: 0.4em 0 0;
171171
font-size: var(--card-font-size);
172172
}
173173
174-
gl-feature-carousel img {
174+
.card img {
175175
max-width: 100%;
176-
height: auto;
177176
}
178177
`;
179178

180179
export const welcomeStyles = css`
181180
${colorScheme} ${typography}
182181
${heroGradient} ${section} ${header}
183-
${carousel}
182+
${cards}
184183
`;

src/webviews/apps/welcome/welcome.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ export class GlWelcomeApp extends GlAppHost<State> {
6161
6262
<div class="section">
6363
<gl-feature-carousel>
64-
<gl-feature-card>
64+
<gl-feature-card class="card">
6565
<img slot="image" src="${this.webroot ?? ''}/media/feature-graph.webp" alt="Commit Graph" />
6666
<h1>Commit Graph</h1>
6767
<p>Visualize your repository's history and interact with commits</p>
6868
<p><a href="command:gitlens.showGraph">Open Commit Graph</a></p>
6969
</gl-feature-card>
70-
<gl-feature-card>
70+
<gl-feature-card class="card">
7171
<img
7272
slot="image"
7373
src="${this.webroot ?? ''}/media/feature-timeline.webp"

0 commit comments

Comments
 (0)