Skip to content

Commit 31cf8b7

Browse files
Fixes incorrect error reason and adds details to output
1 parent 4d94e78 commit 31cf8b7

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/env/node/gk/cli/integration.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const enum CLIInstallErrorReason {
3131
ProxyDownload,
3232
ProxyExtract,
3333
ProxyFetch,
34-
CoreDirectory,
34+
GlobalStorageDirectory,
3535
CoreInstall,
3636
}
3737

@@ -378,8 +378,8 @@ export class GkCliIntegrationProvider implements Disposable {
378378
case CLIInstallErrorReason.ProxyFetch:
379379
case CLIInstallErrorReason.ProxyDownload:
380380
case CLIInstallErrorReason.ProxyExtract:
381-
case CLIInstallErrorReason.CoreDirectory:
382381
case CLIInstallErrorReason.CoreInstall:
382+
case CLIInstallErrorReason.GlobalStorageDirectory:
383383
reason = McpSetupErrorReason.CLILocalInstallFailed;
384384
message = 'Unable to locally install the GitKraken MCP server. Please try again.';
385385
telemetryReason = 'local installation failed';
@@ -593,7 +593,7 @@ export class GkCliIntegrationProvider implements Disposable {
593593
await workspace.fs.createDirectory(globalStoragePath);
594594
} catch (ex) {
595595
throw new CLIInstallError(
596-
CLIInstallErrorReason.CoreDirectory,
596+
CLIInstallErrorReason.GlobalStorageDirectory,
597597
ex instanceof Error ? ex : undefined,
598598
ex instanceof Error ? ex.message : undefined,
599599
);
@@ -657,7 +657,7 @@ export class GkCliIntegrationProvider implements Disposable {
657657
directoryPath = directory[1];
658658
void this.container.storage.store('gk:cli:corePath', directoryPath).catch();
659659
} else {
660-
throw new CLIInstallError(CLIInstallErrorReason.CoreDirectory);
660+
throw new Error(`Failed to find core directory in install output: ${coreInstallOutput}`);
661661
}
662662

663663
Logger.log('CLI install completed.');
@@ -806,12 +806,12 @@ class CLIInstallError extends Error {
806806
case CLIInstallErrorReason.ProxyFetch:
807807
message = 'Failed to fetch proxy';
808808
break;
809-
case CLIInstallErrorReason.CoreDirectory:
810-
message = 'Failed to find core directory in proxy output';
811-
break;
812809
case CLIInstallErrorReason.CoreInstall:
813810
message = 'Failed to install core';
814811
break;
812+
case CLIInstallErrorReason.GlobalStorageDirectory:
813+
message = 'Failed to create global storage directory';
814+
break;
815815
default:
816816
message = 'An unknown error occurred';
817817
break;

0 commit comments

Comments
 (0)